Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1350)

Unified Diff: content/renderer/gpu/gpu_benchmarking_extension.cc

Issue 11229007: Revert "Use WebRenderingStats::Enumerate to populate benchmarking extension renderingStats() fields… (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Add numImplThreadScrolls and numMainThreadScrolls Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/gpu/gpu_rendering_stats.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/gpu/gpu_benchmarking_extension.cc
diff --git a/content/renderer/gpu/gpu_benchmarking_extension.cc b/content/renderer/gpu/gpu_benchmarking_extension.cc
index a781decb48162a55b0ff89a60e86b6af8b486502..08630c18d37405ab595a0831700d53351e0713c4 100644
--- a/content/renderer/gpu/gpu_benchmarking_extension.cc
+++ b/content/renderer/gpu/gpu_benchmarking_extension.cc
@@ -81,30 +81,6 @@ class SkPictureRecorder : public WebViewBenchmarkSupport::PaintClient {
SkPicture picture_;
};
-class RenderingStatsEnumerator
- : public WebRenderingStats::Enumerator,
- public content::GpuRenderingStats::Enumerator {
- public:
- RenderingStatsEnumerator(v8::Handle<v8::Object> stats_object)
- : stats_object_(stats_object) { }
-
- virtual void addInt(const char* name, int value) {
- stats_object_->Set(v8::String::New(name), v8::Integer::New(value));
- }
-
- virtual void addDouble(const char* name, double value) {
- stats_object_->Set(v8::String::New(name), v8::Number::New(value));
- }
-
- virtual void addTimeDelta(const char* name, base::TimeDelta value) {
- stats_object_->Set(v8::String::New(name),
- v8::Number::New(value.InSecondsF()));
- }
-
- private:
- v8::Handle<v8::Object> stats_object_;
-};
-
} // namespace
namespace content {
@@ -194,11 +170,45 @@ class GpuBenchmarkingWrapper : public v8::Extension {
content::GpuRenderingStats gpu_stats;
render_view_impl->GetGpuRenderingStats(&gpu_stats);
-
v8::Handle<v8::Object> stats_object = v8::Object::New();
- RenderingStatsEnumerator enumerator(stats_object);
- stats.enumerateFields(&enumerator);
- gpu_stats.enumerateFields(&enumerator);
+ stats_object->Set(v8::String::New("numAnimationFrames"),
+ v8::Integer::New(stats.numAnimationFrames));
+ stats_object->Set(v8::String::New("numFramesSentToScreen"),
+ v8::Integer::New(stats.numFramesSentToScreen));
+ stats_object->Set(v8::String::New("droppedFrameCount"),
+ v8::Integer::New(stats.droppedFrameCount));
+ stats_object->Set(v8::String::New("totalPaintTimeInSeconds"),
+ v8::Number::New(stats.totalPaintTimeInSeconds));
+ stats_object->Set(v8::String::New("totalRasterizeTimeInSeconds"),
+ v8::Number::New(stats.totalRasterizeTimeInSeconds));
+ stats_object->Set(v8::String::New("totalCommitTimeInSeconds"),
+ v8::Number::New(stats.totalCommitTimeInSeconds));
+ stats_object->Set(v8::String::New("totalCommitCount"),
+ v8::Integer::New(stats.totalCommitCount));
+ stats_object->Set(v8::String::New("numImplThreadScrolls"),
+ v8::Integer::New(stats.numImplThreadScrolls));
+ stats_object->Set(v8::String::New("numMainThreadScrolls"),
+ v8::Integer::New(stats.numMainThreadScrolls));
+
+ stats_object->Set(v8::String::New("globalTextureUploadCount"),
+ v8::Number::New(gpu_stats.global_texture_upload_count));
+ stats_object->Set(
+ v8::String::New("globalTotalTextureUploadTimeInSeconds"),
+ v8::Number::New(
+ gpu_stats.global_total_texture_upload_time.InSecondsF()));
+ stats_object->Set(v8::String::New("textureUploadCount"),
+ v8::Number::New(gpu_stats.texture_upload_count));
+ stats_object->Set(
+ v8::String::New("totalTextureUploadTimeInSeconds"),
+ v8::Number::New(gpu_stats.total_texture_upload_time.InSecondsF()));
+ stats_object->Set(
+ v8::String::New("globalTotalProcessingCommandsTimeInSeconds"),
+ v8::Number::New(
+ gpu_stats.global_total_processing_commands_time.InSecondsF()));
+ stats_object->Set(
+ v8::String::New("totalProcessingCommandsTimeInSeconds"),
+ v8::Number::New(
+ gpu_stats.total_processing_commands_time.InSecondsF()));
return stats_object;
}
« no previous file with comments | « content/common/gpu/gpu_rendering_stats.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698