Issue 11228044: Revert 163477 - Fix glTexSubImage2D for non-32bpp formats.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11228044: Revert 163477 - Fix glTexSubImage2D for non-32bpp formats. (Closed)

Created:
8 years, 2 months ago by Hironori Bono

Modified:
8 years, 2 months ago

Reviewers:
sheu

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 163477 - Fix glTexSubImage2D for non-32bpp formats. The non-mapped upload path for glTexSubImage2D is assuming 32bpp blindly, for all formats. TEST=local build, run on ARM (forcing non-mapped path) BUG=None Change-Id: Ib8ac46646b27faeeb8c19ebb519d321e25c1a8cb Review URL: https://chromiumcodereview.appspot.com/11229040 TBR=sheu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=163485

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -33 lines)			Patch
M	cc/texture.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	cc/texture.cc	View	2 chunks	+3 lines, -20 lines	0 comments	Download
M	cc/texture_uploader.cc	View	5 chunks	+22 lines, -12 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Hironori Bono

8 years, 2 months ago (2012-10-23 04:00:21 UTC) #2

Greetings,

Sorry for reverting your change. Unfortunately, I have reverted your r163477 due
to DCHECK failures on Mac and Linux bots:
*
<http://chromegw.corp.google.com/i/chromium.mac/builders/Mac%2010.6%20Tests%20...>;
*
<http://chromegw.corp.google.com/i/chromium.mac/builders/Mac%2010.7%20Tests%20...>,
and;
*
<http://chromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%20%28...>.

Regards,

Hironori Bono

Expand Messages | Collapse Messages