Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 1122383003: Revert of Lazily initialize MessageLoop for faster thread startup (Closed)

Created:
5 years, 7 months ago by kinuko
Modified:
5 years, 7 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul, Peter Kasting, eroman, brettw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Lazily initialize MessageLoop for faster thread startup (patchset #28 id:870001 of https://codereview.chromium.org/1011683002/) Reason for revert: This introduced flaky assertion failure on some tests http://crbug.com/485157 Original issue's description: > Lazily initialize MessageLoop for faster thread startup > > Summary of the change and background discussion: > https://docs.google.com/a/chromium.org/document/d/1o1vUUOjX3tC7pV5-nxchaGtElo4NwtzKOAb4Zm09ezw/edit# > > This implements approach 1 in the doc. > Approach 2: https://codereview.chromium.org/1086663002/ > Approach 3: https://codereview.chromium.org/1058603004/ > > Discussion thread: > https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/2t6lB8hUgYw > > BUG=465458 > > Committed: https://crrev.com/f1f70cb5ebe24d85c575396f026a415ed0fe9afc > Cr-Commit-Position: refs/heads/master@{#328347} TBR=dalecurtis@chromium.org,rvargas@chromium.org,tommi@chromium.org,mark@chromium.org,thakis@chromium.org,danakj@chromium.org,pauljensen@chromium.org,jam@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=465458 Committed: https://crrev.com/448203e533c5bdb3ba11df536d100c38d15b6b51 Cr-Commit-Position: refs/heads/master@{#328674}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -280 lines) Patch
M base/message_loop/incoming_task_queue.h View 3 chunks +0 lines, -10 lines 0 comments Download
M base/message_loop/incoming_task_queue.cc View 3 chunks +10 lines, -26 lines 0 comments Download
M base/message_loop/message_loop.h View 5 chunks +8 lines, -37 lines 0 comments Download
M base/message_loop/message_loop.cc View 4 chunks +33 lines, -47 lines 0 comments Download
M base/message_loop/message_loop_proxy_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M base/message_loop/message_loop_proxy_impl.cc View 1 chunk +1 line, -6 lines 0 comments Download
M base/message_loop/message_pump_perftest.cc View 3 chunks +5 lines, -0 lines 0 comments Download
M base/threading/platform_thread.h View 1 chunk +0 lines, -4 lines 0 comments Download
M base/threading/platform_thread_win.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M base/threading/thread.h View 7 chunks +12 lines, -24 lines 0 comments Download
M base/threading/thread.cc View 7 chunks +93 lines, -92 lines 0 comments Download
M base/threading/thread_id_name_manager_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M base/threading/thread_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/io_thread.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/io_thread.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/metrics/thread_watcher_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_registrar_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/browser_thread_impl.cc View 1 chunk +7 lines, -1 line 0 comments Download
M content/public/browser/browser_thread_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/test/test_browser_thread.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/test/test_browser_thread.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/android/network_change_notifier_android.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kinuko
Created Revert of Lazily initialize MessageLoop for faster thread startup
5 years, 7 months ago (2015-05-07 01:26:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1122383003/1
5 years, 7 months ago (2015-05-07 01:27:21 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-07 01:30:07 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 01:31:17 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/448203e533c5bdb3ba11df536d100c38d15b6b51
Cr-Commit-Position: refs/heads/master@{#328674}

Powered by Google App Engine
This is Rietveld 408576698