content/browser/browser_thread_impl.cc - Issue 1122383003: Revert of Lazily initialize MessageLoop for faster thread startup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_thread_impl.cc

Issue 1122383003: Revert of Lazily initialize MessageLoop for faster thread startup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/sync_backend_registrar_unittest.cc ('k') | content/public/browser/browser_thread_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_thread_impl.cc

diff --git a/content/browser/browser_thread_impl.cc b/content/browser/browser_thread_impl.cc

index 4ae6607f7a9cc9c79914dbe76835883f95fbf71b..78e3836dadeef038f5db6e1a7fd0b1a3352fd8b6 100644

--- a/content/browser/browser_thread_impl.cc

+++ b/content/browser/browser_thread_impl.cc

@@ -159,8 +159,14 @@

AtomicWord stored_pointer = base::subtle::NoBarrier_Load(storage);

BrowserThreadDelegate* delegate =

reinterpret_cast<BrowserThreadDelegate*>(stored_pointer);

- if (delegate)

+ if (delegate) {

delegate->Init();

+ message_loop()->PostTask(FROM_HERE,

+ base::Bind(&BrowserThreadDelegate::InitAsync,

+ // Delegate is expected to exist for the

+ // duration of the thread's lifetime

+ base::Unretained(delegate)));

+ }

}

// We disable optimizations for this block of functions so the compiler doesn't

« no previous file with comments | « chrome/browser/sync/glue/sync_backend_registrar_unittest.cc ('k') | content/public/browser/browser_thread_delegate.h » ('j') | no next file with comments »