chrome/browser/metrics/thread_watcher_unittest.cc - Issue 1122383003: Revert of Lazily initialize MessageLoop for faster thread startup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/thread_watcher_unittest.cc

Issue 1122383003: Revert of Lazily initialize MessageLoop for faster thread startup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/metrics/thread_watcher_unittest.cc

diff --git a/chrome/browser/metrics/thread_watcher_unittest.cc b/chrome/browser/metrics/thread_watcher_unittest.cc

index 00171b8052257fba0f31b0854d259b2b9fb5df30..4b3c457a36baa839dd65c3b6b9161fc88d152adc 100644

--- a/chrome/browser/metrics/thread_watcher_unittest.cc

+++ b/chrome/browser/metrics/thread_watcher_unittest.cc

@@ -257,9 +257,9 @@

db_thread_.reset(new content::TestBrowserThread(BrowserThread::DB));

io_thread_.reset(new content::TestBrowserThread(BrowserThread::IO));

watchdog_thread_.reset(new WatchDogThread());

- db_thread_->StartAndWaitForTesting();

- io_thread_->StartAndWaitForTesting();

- watchdog_thread_->StartAndWaitForTesting();

+ db_thread_->Start();

+ io_thread_->Start();

+ watchdog_thread_->Start();

WatchDogThread::PostTask(

FROM_HERE,

@@ -691,7 +691,7 @@

content::TestBrowserThread ui_thread(BrowserThread::UI, &message_loop_for_ui);

scoped_ptr<WatchDogThread> watchdog_thread_(new WatchDogThread());

- watchdog_thread_->StartAndWaitForTesting();

+ watchdog_thread_->Start();

// See http://crbug.com/347887.

// StartWatchingAll() will PostDelayedTask to create g_thread_watcher_list_,

« no previous file with comments | « chrome/browser/io_thread.cc ('k') | chrome/browser/sync/glue/sync_backend_registrar_unittest.cc » ('j') | no next file with comments »