Add the enable_polymer_v08 flag for gn. Equivalent gyp change was

Add the enable_polymer_v08 flag for gn. Equivalent gyp change was
https://codereview.chromium.org/1118673004/

BUG=483080
Committed: https://crrev.com/8e9e1b029b557bdbd1462c56e7f0f784922b185c
Cr-Commit-Position: refs/heads/master@{#328204}

[Jeremy Klein, 2015-05-02 00:32:00]

jlklein@chromium.org changed reviewers:
+ brettw@chromium.org

[Jeremy Klein, 2015-05-02 00:32:01]

Hey Brett, I wasn't sure whether this flag should go in features.gni, ui.gni, or
elsewhere. Let me know if I should move it. Note that it will be removed after
the M44 branch point.

[brettw, 2015-05-04 17:06:32]

https://codereview.chromium.org/1120203003/diff/40001/ui/resources/BUILD.gn
File ui/resources/BUILD.gn (right):

https://codereview.chromium.org/1120203003/diff/40001/ui/resources/BUILD.gn#n...
ui/resources/BUILD.gn:40: if (enable_polymer_v08) {
Are we expecting this flag to be used all over the place or just here? What's
the lowest-level component that knows or should control this setting?

In the GN build we try to minimize the global flags. If you just want a flag in
one file for example, you can put a declare_args block in this file. The
features.gni file is really a hack for legacy GYP flags.

[mark a. foltz, 2015-05-04 17:55:18]

mfoltz@chromium.org changed reviewers:
+ mfoltz@chromium.org

[mark a. foltz, 2015-05-04 17:55:19]

https://codereview.chromium.org/1120203003/diff/40001/ui/resources/BUILD.gn
File ui/resources/BUILD.gn (right):

https://codereview.chromium.org/1120203003/diff/40001/ui/resources/BUILD.gn#n...
ui/resources/BUILD.gn:40: if (enable_polymer_v08) {
On 2015/05/04 17:06:32, brettw wrote:
> Are we expecting this flag to be used all over the place or just here? What's
> the lowest-level component that knows or should control this setting?
> 
> In the GN build we try to minimize the global flags. If you just want a flag
in
> one file for example, you can put a declare_args block in this file. The
> features.gni file is really a hack for legacy GYP flags.

Maybe it could go into grit_rule.gni, and the define added automatically to all
grit() invocations.

[Jeremy Klein, 2015-05-04 18:04:48]

On 2015/05/04 17:06:32, brettw wrote:
> https://codereview.chromium.org/1120203003/diff/40001/ui/resources/BUILD.gn
> File ui/resources/BUILD.gn (right):
> 
>
https://codereview.chromium.org/1120203003/diff/40001/ui/resources/BUILD.gn#n...
> ui/resources/BUILD.gn:40: if (enable_polymer_v08) {
> Are we expecting this flag to be used all over the place or just here? What's
> the lowest-level component that knows or should control this setting?
> 
> In the GN build we try to minimize the global flags. If you just want a flag
in
> one file for example, you can put a declare_args block in this file. The
> features.gni file is really a hack for legacy GYP flags.

Yep, it's only used here and will only be here for a few weeks. Moved the flag
into the BUILD.gn.

This is so much more sane than the equivalent gyp CL :-).

[brettw, 2015-05-04 21:40:53]

lgtm

[Jeremy Klein, 2015-05-04 21:45:30]

The CQ bit was checked by jlklein@chromium.org

[commit-bot: I haz the power, 2015-05-04 21:47:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1120203003/60001

[commit-bot: I haz the power, 2015-05-04 22:15:01]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-05-04 22:16:23]

Patchset 4 (id:??) landed as
https://crrev.com/8e9e1b029b557bdbd1462c56e7f0f784922b185c
Cr-Commit-Position: refs/heads/master@{#328204}