Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 1118673004: Add a build flag to include polymer 0.8 in the binary (Closed)

Created:
5 years, 7 months ago by Jeremy Klein
Modified:
5 years, 7 months ago
Reviewers:
oshima, Dan Beam
CC:
chromium-reviews, khorimoto+watch-md-settings_chromium.org, michaelpg+watch-polymer_chromium.org, michaelpg+watch-md-settings_chromium.org, jhawkins+watch-md-settings_chromium.org, orenb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org, oshima+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, raymes
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a build flag to include polymer 0.8 in the binary BUG=483080 Committed: https://crrev.com/f0c5abbfb8e955069a64a8bfd52fbe4dc7a38522 Cr-Commit-Position: refs/heads/master@{#327959}

Patch Set 1 : Do it all in ui_resources.gyp #

Patch Set 2 : Change to enable_polymer_v08 and ensure it works with the default #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -34 lines) Patch
M ui/resources/ui_resources.gyp View 1 2 chunks +9 lines, -0 lines 0 comments Download
M ui/webui/resources/cr_elements_resources.grdp View 1 1 chunk +11 lines, -9 lines 0 comments Download
M ui/webui/resources/polymer_resources.grdp View 1 1 chunk +27 lines, -25 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
Jeremy Klein
5 years, 7 months ago (2015-05-01 00:05:46 UTC) #2
Dan Beam
lgtm but use_new_polymer or enable_new_polymer sounds better as 08 and 08% are weird lookin'
5 years, 7 months ago (2015-05-01 00:49:38 UTC) #4
Jeremy Klein
On 2015/05/01 00:49:38, Dan Beam wrote: > lgtm but use_new_polymer or enable_new_polymer sounds better as ...
5 years, 7 months ago (2015-05-01 01:01:14 UTC) #5
Jeremy Klein
On 2015/05/01 00:49:38, Dan Beam wrote: > lgtm but use_new_polymer or enable_new_polymer sounds better as ...
5 years, 7 months ago (2015-05-01 01:01:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1118673004/40001
5 years, 7 months ago (2015-05-01 01:25:42 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/60453)
5 years, 7 months ago (2015-05-01 01:34:28 UTC) #11
Jeremy Klein
+oshima for ui/resources/ui_resources.gyp
5 years, 7 months ago (2015-05-01 01:55:10 UTC) #13
oshima
ui/resources lgtm
5 years, 7 months ago (2015-05-01 18:20:35 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1118673004/40001
5 years, 7 months ago (2015-05-01 18:26:00 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 7 months ago (2015-05-01 19:35:57 UTC) #17
commit-bot: I haz the power
5 years, 7 months ago (2015-05-01 19:36:48 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f0c5abbfb8e955069a64a8bfd52fbe4dc7a38522
Cr-Commit-Position: refs/heads/master@{#327959}

Powered by Google App Engine
This is Rietveld 408576698