Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3754)

Unified Diff: runtime/observatory/lib/src/elements/eval_link.dart

Issue 1120133002: Rework error handling in the service protocol and in Observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: fix tests Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/eval_link.dart
diff --git a/runtime/observatory/lib/src/elements/eval_link.dart b/runtime/observatory/lib/src/elements/eval_link.dart
index e13aed127cc24f3a85afe91959748e1da80904db..aa8be4efd8e374fa43a7289a6838adaa73b52722 100644
--- a/runtime/observatory/lib/src/elements/eval_link.dart
+++ b/runtime/observatory/lib/src/elements/eval_link.dart
@@ -5,17 +5,19 @@
library eval_link_element;
import 'package:observatory/service.dart';
+import 'observatory_element.dart';
import 'package:polymer/polymer.dart';
@CustomTag('eval-link')
-class EvalLinkElement extends PolymerElement {
+class EvalLinkElement extends ObservatoryElement {
EvalLinkElement.created() : super.created();
@observable bool busy = false;
@published String label = "[evaluate]";
@published var callback = null;
@published var expr = '';
- @published ServiceObject result = null;
+ @published var result = null;
+ @published var error = null;
void evalNow(var a, var b, var c) {
if (busy) {
@@ -25,10 +27,13 @@ class EvalLinkElement extends PolymerElement {
busy = true;
result = null;
callback(expr).then((ServiceObject obj) {
- result = obj;
- }).whenComplete(() {
- busy = false;
- });
+ result = obj;
+ }).catchError((e, st) {
+ error = e.message;
+ app.handleException(e, st);
+ }).whenComplete(() {
+ busy = false;
+ });
}
}
}
« no previous file with comments | « runtime/observatory/lib/src/elements/eval_box.html ('k') | runtime/observatory/lib/src/elements/eval_link.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698