Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1544)

Unified Diff: runtime/observatory/lib/src/elements/eval_link.html

Issue 1120133002: Rework error handling in the service protocol and in Observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: fix tests Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/eval_link.html
diff --git a/runtime/observatory/lib/src/elements/eval_link.html b/runtime/observatory/lib/src/elements/eval_link.html
index d12f620aef3aee0f8be3e2b958348f391b7495d2..1fdb584b8069ed541dff16c6c7427fd4cb98405f 100644
--- a/runtime/observatory/lib/src/elements/eval_link.html
+++ b/runtime/observatory/lib/src/elements/eval_link.html
@@ -1,8 +1,9 @@
<link rel="import" href="../../../../packages/polymer/polymer.html">
<link rel="import" href="instance_ref.html">
<link rel="import" href="error_ref.html">
+<link rel="import" href="observatory_element.html">
-<polymer-element name="eval-link">
+<polymer-element name="eval-link" extends="observatory-element">
<template>
<style>
.idle {
@@ -21,8 +22,13 @@
<template if="{{ !busy }}">
<span class="idle"><a on-click="{{ evalNow }}">{{ label }}</a></span>
</template>
- <template if="{{ result != null }}">
- = <any-service-ref ref="{{ result }}"></any-service-ref>
+ <template if="{{ error != null }}">
+ = <span style="color:red">{{ error }}</span>
+ </template>
+ <template if="{{ error == null }}">
+ <template if="{{ result != null }}">
+ = <any-service-ref ref="{{ result }}"></any-service-ref>
+ </template>
</template>
</template>
</polymer-element>
« no previous file with comments | « runtime/observatory/lib/src/elements/eval_link.dart ('k') | runtime/observatory/lib/src/elements/field_view.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698