Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: runtime/observatory/lib/src/elements/eval_box.html

Issue 1120133002: Rework error handling in the service protocol and in Observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: fix tests Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/eval_box.html
diff --git a/runtime/observatory/lib/src/elements/eval_box.html b/runtime/observatory/lib/src/elements/eval_box.html
index b556358ec721fdf3586403115ae520794e3cef86..4df73fa1b7acd8966bb7a5d76bab05681f50252b 100644
--- a/runtime/observatory/lib/src/elements/eval_box.html
+++ b/runtime/observatory/lib/src/elements/eval_box.html
@@ -74,11 +74,16 @@
expr="{{ result['expr'] }}">{{ result['expr'] }}</a>
</td>
<td class="historyValue">
- <template if="{{ result['value'] == null }}">
- <div style="color:#aaa;cursor:wait;">&lt;pending&gt;</div>
+ <template if="{{ result['error'] != null}}">
+ <div style="color:red">{{ result['error'] }}</div>
</template>
- <template if="{{ result['value'] != null }}">
- <any-service-ref ref="{{ result['value'] }}"></any-service-ref>
+ <template if="{{ result['error'] == null}}">
+ <template if="{{ result['value'] != null }}">
+ <any-service-ref ref="{{ result['value'] }}"></any-service-ref>
+ </template>
+ <template if="{{ result['value'] == null }}">
+ <div style="color:#aaa;cursor:wait;">&lt;pending&gt;</div>
+ </template>
</template>
</td>
</tr>
« no previous file with comments | « runtime/observatory/lib/src/elements/eval_box.dart ('k') | runtime/observatory/lib/src/elements/eval_link.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698