Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 11201002: Removes worskpace 1 code. Will rename next. (Closed)

Created:
8 years, 2 months ago by sky
Modified:
8 years, 2 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove more code #

Total comments: 5

Patch Set 3 : Remove constants and add back kDisableLoginAnimations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -2355 lines) Patch
M ash/ash.gyp View 1 2 4 chunks +0 lines, -12 lines 0 comments Download
M ash/ash_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/ash_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/root_window_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/root_window_controller.cc View 3 chunks +8 lines, -19 lines 0 comments Download
M ash/shell.cc View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M ash/shell/window_watcher.cc View 2 chunks +1 line, -7 lines 0 comments Download
M ash/wm/activation_controller.cc View 3 chunks +2 lines, -8 lines 0 comments Download
M ash/wm/always_on_top_controller.h View 2 chunks +4 lines, -8 lines 0 comments Download
M ash/wm/always_on_top_controller.cc View 2 chunks +6 lines, -24 lines 0 comments Download
M ash/wm/base_layout_manager.h View 1 1 chunk +1 line, -6 lines 0 comments Download
M ash/wm/base_layout_manager.cc View 1 7 chunks +5 lines, -30 lines 0 comments Download
M ash/wm/frame_painter.cc View 3 chunks +3 lines, -7 lines 0 comments Download
M ash/wm/shelf_layout_manager.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M ash/wm/stacking_controller.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/wm/window_animations.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M ash/wm/window_animations.cc View 1 5 chunks +2 lines, -88 lines 0 comments Download
M ash/wm/window_animations_unittest.cc View 1 2 chunks +0 lines, -103 lines 0 comments Download
M ash/wm/window_cycle_controller.cc View 1 chunk +2 lines, -4 lines 0 comments Download
D ash/wm/workspace/base_workspace_manager.h View 1 chunk +0 lines, -48 lines 0 comments Download
D ash/wm/workspace/managed_workspace.h View 1 chunk +0 lines, -35 lines 0 comments Download
D ash/wm/workspace/managed_workspace.cc View 1 chunk +0 lines, -31 lines 0 comments Download
D ash/wm/workspace/maximized_workspace.h View 1 chunk +0 lines, -37 lines 0 comments Download
D ash/wm/workspace/maximized_workspace.cc View 1 chunk +0 lines, -52 lines 0 comments Download
M ash/wm/workspace/multi_window_resize_controller_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
D ash/wm/workspace/workspace.h View 1 chunk +0 lines, -96 lines 0 comments Download
D ash/wm/workspace/workspace.cc View 1 chunk +0 lines, -71 lines 0 comments Download
M ash/wm/workspace/workspace_event_handler_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
D ash/wm/workspace/workspace_layout_manager.h View 1 chunk +0 lines, -68 lines 0 comments Download
D ash/wm/workspace/workspace_layout_manager.cc View 1 chunk +0 lines, -116 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager2_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/wm/workspace/workspace_manager.h View 1 chunk +0 lines, -145 lines 0 comments Download
D ash/wm/workspace/workspace_manager.cc View 1 chunk +0 lines, -368 lines 0 comments Download
M ash/wm/workspace/workspace_manager2.h View 3 chunks +17 lines, -11 lines 0 comments Download
M ash/wm/workspace/workspace_manager2.cc View 1 chunk +0 lines, -4 lines 0 comments Download
D ash/wm/workspace/workspace_manager_unittest.cc View 1 chunk +0 lines, -741 lines 0 comments Download
M ash/wm/workspace_controller.h View 3 chunks +2 lines, -18 lines 0 comments Download
M ash/wm/workspace_controller.cc View 2 chunks +2 lines, -31 lines 0 comments Download
M ash/wm/workspace_controller_test_helper.h View 1 2 chunks +1 line, -7 lines 0 comments Download
M ash/wm/workspace_controller_test_helper.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/base_login_display_host.cc View 1 2 3 chunks +1 line, -118 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sky
Nikita: chromeos change Ben: the rest
8 years, 2 months ago (2012-10-16 22:43:27 UTC) #1
Ben Goodger (Google)
cool. lgtm
8 years, 2 months ago (2012-10-16 23:14:40 UTC) #2
sky
Nikita, I'm TRBing you.
8 years, 2 months ago (2012-10-17 14:16:34 UTC) #3
Nikita (slow)
http://codereview.chromium.org/11201002/diff/2001/chrome/browser/chromeos/login/base_login_display_host.cc File chrome/browser/chromeos/login/base_login_display_host.cc (left): http://codereview.chromium.org/11201002/diff/2001/chrome/browser/chromeos/login/base_login_display_host.cc#oldcode335 chrome/browser/chromeos/login/base_login_display_host.cc:335: bool disable_animations = command_line->HasSwitch( Is this switch to disable ...
8 years, 2 months ago (2012-10-17 14:43:11 UTC) #4
sky
I removed all the unneeded constants. New patch uploaded. Thanks, -Scott http://codereview.chromium.org/11201002/diff/2001/chrome/browser/chromeos/login/base_login_display_host.cc File chrome/browser/chromeos/login/base_login_display_host.cc (left): ...
8 years, 2 months ago (2012-10-17 14:56:02 UTC) #5
Nikita (slow)
8 years, 2 months ago (2012-10-17 15:02:44 UTC) #6
lgtm

Powered by Google App Engine
This is Rietveld 408576698