Don't try to use -MMD / .o.d depfiles for ninja with .s files.

Don't try to use -MMD / .o.d depfiles for ninja with .s files.

BUG=gyp:297
r1521

[Nico, 2012-10-18 00:32:12]

Needs test.

Does Evan's suggestion work too?

[Ami GONE FROM CHROMIUM, 2012-10-18 00:43:05]

On 2012/10/18 00:32:12, Nico wrote:
> Needs test.

Suggestions of copy/pasta source?

> Does Evan's suggestion work too?

Nope.
A generated edge like:

build $
   
obj/third_party/webrtc/common_audio/signal_processing/signal_processing.complex_bit_reverse_arm.o:
$
    cc $
   
../../third_party/webrtc/common_audio/signal_processing/complex_bit_reverse_arm.s
  depfile = 

still always recompiles:

(cros) (master) fischman@fischman-linux ~/chrome_root/src $ ../ninja
obj/third_party/webrtc/common_audio/signal_processing/signal_processing.complex_bit_reverse_arm.o|cat
ninja: Entering directory `out_daisy/Debug'
[0/1/0] CC
obj/third_party/webrtc/common_audio/signal_processing/signal_processing.complex_bit_reverse_arm.o
(cros) (master) fischman@fischman-linux ~/chrome_root/src $ ../ninja
obj/third_party/webrtc/common_audio/signal_processing/signal_processing.complex_bit_reverse_arm.o|cat
ninja: Entering directory `out_daisy/Debug'
[0/1/0] CC
obj/third_party/webrtc/common_audio/signal_processing/signal_processing.complex_bit_reverse_arm.o

[Ami GONE FROM CHROMIUM, 2012-10-18 02:39:04]

Added a test.

Trybots are all grey on rietveld (launched with: git cl try).  Can you put it
through the gyp trybots for me?

[Ami GONE FROM CHROMIUM, 2012-10-18 07:04:34]

finally have all-green bot runs.

[Nico, 2012-10-18 18:09:39]

lgtm

https://codereview.chromium.org/11186038/diff/2005/test/ninja/s-needs-no-depf...
File test/ninja/s-needs-no-depfiles/gyptest-s-needs-no-depfiles.py (right):

https://codereview.chromium.org/11186038/diff/2005/test/ninja/s-needs-no-depf...
test/ninja/s-needs-no-depfiles/gyptest-s-needs-no-depfiles.py:9: were used for
them (since clang & gcc ignore -MMD when building .s->.o).
"when building .s->o on linux" (doesn't happen on os x)

https://codereview.chromium.org/11186038/diff/2005/test/ninja/s-needs-no-depf...
test/ninja/s-needs-no-depfiles/gyptest-s-needs-no-depfiles.py:30:
test.write(os.path.join(test.workdir, 'empty.s'), '')
Can't you just check in an empty 'empty.s'?

[Ami GONE FROM CHROMIUM, 2012-10-18 18:14:38]

https://codereview.chromium.org/11186038/diff/2005/test/ninja/s-needs-no-depf...
File test/ninja/s-needs-no-depfiles/gyptest-s-needs-no-depfiles.py (right):

https://codereview.chromium.org/11186038/diff/2005/test/ninja/s-needs-no-depf...
test/ninja/s-needs-no-depfiles/gyptest-s-needs-no-depfiles.py:9: were used for
them (since clang & gcc ignore -MMD when building .s->.o).
On 2012/10/18 18:09:39, Nico wrote:
> "when building .s->o on linux" (doesn't happen on os x)

Are you sure?  The interwebz tell me otherwise.

(does this test pass for you on osx without the corresponding change to
ninja.py?)

https://codereview.chromium.org/11186038/diff/2005/test/ninja/s-needs-no-depf...
test/ninja/s-needs-no-depfiles/gyptest-s-needs-no-depfiles.py:30:
test.write(os.path.join(test.workdir, 'empty.s'), '')
On 2012/10/18 18:09:39, Nico wrote:
> Can't you just check in an empty 'empty.s'?

I did that with an earlier revision, but it made git try cry b/c one of the
patching steps apparently can't cope with empty files...

[Nico, 2012-10-18 18:30:21]

(still lgtm)

https://codereview.chromium.org/11186038/diff/2005/test/ninja/s-needs-no-depf...
File test/ninja/s-needs-no-depfiles/gyptest-s-needs-no-depfiles.py (right):

https://codereview.chromium.org/11186038/diff/2005/test/ninja/s-needs-no-depf...
test/ninja/s-needs-no-depfiles/gyptest-s-needs-no-depfiles.py:9: were used for
them (since clang & gcc ignore -MMD when building .s->.o).
On 2012/10/18 18:14:38, Ami Fischman wrote:
> On 2012/10/18 18:09:39, Nico wrote:
> > "when building .s->o on linux" (doesn't happen on os x)
> 
> Are you sure?

Pretty sure. See the ninja-build thread on this, where I checked.

> (does this test pass for you on osx without the corresponding change to
> ninja.py?)

Yes:

hummer:gyp-rw thakis$ python gyptest.py
test/ninja/s-needs-no-depfiles/gyptest-s-needs-no-depfiles.py 
PYTHONPATH=/Volumes/MacintoshHD2/src/gyp-rw/test/lib
TESTGYP_FORMAT=make
/usr/bin/python test/ninja/s-needs-no-depfiles/gyptest-s-needs-no-depfiles.py
Invalid test for 'make' format; skipping test.
NO RESULT
TESTGYP_FORMAT=ninja
/usr/bin/python test/ninja/s-needs-no-depfiles/gyptest-s-needs-no-depfiles.py
PASSED
TESTGYP_FORMAT=xcode
/usr/bin/python test/ninja/s-needs-no-depfiles/gyptest-s-needs-no-depfiles.py
Invalid test for 'xcode' format; skipping test.
NO RESULT

No result from the following 2 tests:
	test/ninja/s-needs-no-depfiles/gyptest-s-needs-no-depfiles.py
	test/ninja/s-needs-no-depfiles/gyptest-s-needs-no-depfiles.py
hummer:gyp-rw thakis$ svn revert pylib/gyp/generator/ninja.py
Reverted 'pylib/gyp/generator/ninja.py'
^P^Phummer:gyp-rw thakpython gyptest.py
test/ninja/s-needs-no-depfiles/gyptest-s-needs-no-depfiles.py -f ninja
PYTHONPATH=/Volumes/MacintoshHD2/src/gyp-rw/test/lib
TESTGYP_FORMAT=ninja
/usr/bin/python test/ninja/s-needs-no-depfiles/gyptest-s-needs-no-depfiles.py
PASSED
hummer:gyp-rw thakis$

https://codereview.chromium.org/11186038/diff/2005/test/ninja/s-needs-no-depf...
test/ninja/s-needs-no-depfiles/gyptest-s-needs-no-depfiles.py:30:
test.write(os.path.join(test.workdir, 'empty.s'), '')
On 2012/10/18 18:14:38, Ami Fischman wrote:
> On 2012/10/18 18:09:39, Nico wrote:
> > Can't you just check in an empty 'empty.s'?
> 
> I did that with an earlier revision, but it made git try cry b/c one of the
> patching steps apparently can't cope with empty files...

"# This file intentionally left empty." Regular bots can handle empty files too
I think, so maybe that's not even necessary.