Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Unified Diff: test/ninja/s-needs-no-depfiles/s-needs-no-depfiles.gyp

Issue 11186038: Don't try to use -MMD / .o.d depfiles for ninja with .s files. (Closed) Base URL: http://git.chromium.org/external/gyp.git@master
Patch Set: Clarify comment and include explicit empty.s file. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/ninja/s-needs-no-depfiles/gyptest-s-needs-no-depfiles.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/ninja/s-needs-no-depfiles/s-needs-no-depfiles.gyp
diff --git a/test/dependencies/double_dependent.gyp b/test/ninja/s-needs-no-depfiles/s-needs-no-depfiles.gyp
similarity index 67%
copy from test/dependencies/double_dependent.gyp
copy to test/ninja/s-needs-no-depfiles/s-needs-no-depfiles.gyp
index 334caff723ce8e2722e5a07c129e3658d04543b1..bd66b1a70a82c34199bf80439ce25be2451c6bf5 100644
--- a/test/dependencies/double_dependent.gyp
+++ b/test/ninja/s-needs-no-depfiles/s-needs-no-depfiles.gyp
@@ -5,8 +5,9 @@
{
'targets': [
{
- 'target_name': 'double_dependent',
- 'type': 'none',
+ 'target_name': 'empty',
+ 'type': 'shared_library',
+ 'sources': [ 'empty.s' ],
},
],
}
« no previous file with comments | « test/ninja/s-needs-no-depfiles/gyptest-s-needs-no-depfiles.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698