Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: extensions/browser/updater/update_service_browsertest.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unneeded Pass() calls Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/updater/extension_downloader.cc ('k') | google_apis/drive/base_requests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/updater/update_service_browsertest.cc
diff --git a/extensions/browser/updater/update_service_browsertest.cc b/extensions/browser/updater/update_service_browsertest.cc
index c4ff0ef0cb56fe50262a9f5dc74628a54fb4a366..bd9a55eca666550e7f2fe6a55023ae6432e4b553 100644
--- a/extensions/browser/updater/update_service_browsertest.cc
+++ b/extensions/browser/updater/update_service_browsertest.cc
@@ -105,7 +105,7 @@ class FakeUpdateURLFetcherFactory : public net::URLFetcherFactory {
}
// net::URLFetcherFactory:
- net::URLFetcher* CreateURLFetcher(
+ scoped_ptr<net::URLFetcher> CreateURLFetcher(
int id,
const GURL& url,
net::URLFetcher::RequestType request_type,
@@ -122,7 +122,7 @@ class FakeUpdateURLFetcherFactory : public net::URLFetcherFactory {
}
private:
- net::URLFetcher* CreateUpdateManifestFetcher(
+ scoped_ptr<net::URLFetcher> CreateUpdateManifestFetcher(
const GURL& url,
net::URLFetcherDelegate* delegate) {
// If we have a fake CRX for the ID, return a fake update blob for it.
@@ -138,13 +138,14 @@ class FakeUpdateURLFetcherFactory : public net::URLFetcherFactory {
else
response = CreateFakeUpdateResponse(extension_id, iter->second.size());
}
- return new net::FakeURLFetcher(url, delegate, response.first,
- response.second,
- net::URLRequestStatus::SUCCESS);
+ return scoped_ptr<net::URLFetcher>(
+ new net::FakeURLFetcher(url, delegate, response.first, response.second,
+ net::URLRequestStatus::SUCCESS));
}
- net::URLFetcher* CreateCrxFetcher(const GURL& url,
- net::URLFetcherDelegate* delegate) {
+ scoped_ptr<net::URLFetcher> CreateCrxFetcher(
+ const GURL& url,
+ net::URLFetcherDelegate* delegate) {
FakeResponse response;
std::string extension_id = url.path().substr(1, 32);
const auto& iter = fake_extensions_.find(extension_id);
@@ -156,7 +157,7 @@ class FakeUpdateURLFetcherFactory : public net::URLFetcherFactory {
new net::FakeURLFetcher(url, delegate, response.first, response.second,
net::URLRequestStatus::SUCCESS);
fetcher->SetResponseFilePath(base::FilePath::FromUTF8Unsafe(url.path()));
- return fetcher;
+ return scoped_ptr<net::URLFetcher>(fetcher);
}
std::map<std::string, std::string> fake_extensions_;
« no previous file with comments | « extensions/browser/updater/extension_downloader.cc ('k') | google_apis/drive/base_requests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698