google_apis/drive/base_requests.cc - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/drive/base_requests.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unneeded Pass() calls Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: google_apis/drive/base_requests.cc

diff --git a/google_apis/drive/base_requests.cc b/google_apis/drive/base_requests.cc

index bcd1bab623ebb427ac50d69b004898ce8ab6c7a3..164be2e16a3b3fb7197bed7be2706bbefaf78b2a 100644

--- a/google_apis/drive/base_requests.cc

+++ b/google_apis/drive/base_requests.cc

@@ -354,7 +354,7 @@ void UrlFetchRequestBase::StartAfterPrepare(

DVLOG(1) << "URL: " << url.spec();

URLFetcher::RequestType request_type = GetRequestType();

- url_fetcher_.reset(URLFetcher::Create(url, request_type, this));

+ url_fetcher_ = URLFetcher::Create(url, request_type, this);

url_fetcher_->SetRequestContext(sender_->url_request_context_getter());

// Always set flags to neither send nor save cookies.

url_fetcher_->SetLoadFlags(

« no previous file with comments | « extensions/browser/updater/update_service_browsertest.cc ('k') | google_apis/gaia/gaia_auth_fetcher.h » ('j') | no next file with comments »