Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: extensions/browser/updater/extension_downloader.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unneeded Pass() calls Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/updater/extension_downloader.cc
diff --git a/extensions/browser/updater/extension_downloader.cc b/extensions/browser/updater/extension_downloader.cc
index e1e61f850d6958151c90fcd7a322e024ad5687ec..87958ae4a64d84051a1e130bdc5f22abdd243da7 100644
--- a/extensions/browser/updater/extension_downloader.cc
+++ b/extensions/browser/updater/extension_downloader.cc
@@ -473,11 +473,9 @@ void ExtensionDownloader::CreateManifestFetcher() {
<< " for " << id_list;
}
- manifest_fetcher_.reset(
- net::URLFetcher::Create(kManifestFetcherId,
- manifests_queue_.active_request()->full_url(),
- net::URLFetcher::GET,
- this));
+ manifest_fetcher_ = net::URLFetcher::Create(
+ kManifestFetcherId, manifests_queue_.active_request()->full_url(),
+ net::URLFetcher::GET, this);
manifest_fetcher_->SetRequestContext(request_context_.get());
manifest_fetcher_->SetLoadFlags(net::LOAD_DO_NOT_SEND_COOKIES |
net::LOAD_DO_NOT_SAVE_COOKIES |
@@ -762,8 +760,8 @@ void ExtensionDownloader::CacheInstallDone(
void ExtensionDownloader::CreateExtensionFetcher() {
const ExtensionFetch* fetch = extensions_queue_.active_request();
- extension_fetcher_.reset(net::URLFetcher::Create(
- kExtensionFetcherId, fetch->url, net::URLFetcher::GET, this));
+ extension_fetcher_ = net::URLFetcher::Create(kExtensionFetcherId, fetch->url,
+ net::URLFetcher::GET, this);
extension_fetcher_->SetRequestContext(request_context_.get());
extension_fetcher_->SetAutomaticallyRetryOnNetworkChanges(3);

Powered by Google App Engine
This is Rietveld 408576698