Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: components/signin/core/browser/gaia_cookie_manager_service.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unneeded Pass() calls Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/gaia_cookie_manager_service.cc
diff --git a/components/signin/core/browser/gaia_cookie_manager_service.cc b/components/signin/core/browser/gaia_cookie_manager_service.cc
index 36f2dd085a73e4e9fd85095f8fe28b445cddd334..e8a0cb76802947ef5702a025e003df2f7c585d55 100644
--- a/components/signin/core/browser/gaia_cookie_manager_service.cc
+++ b/components/signin/core/browser/gaia_cookie_manager_service.cc
@@ -176,7 +176,7 @@ void GaiaCookieManagerService::ExternalCcResultFetcher::
if (dict->GetString("carryBackToken", &token) &&
dict->GetString("url", &url)) {
results_[token] = "null";
- net::URLFetcher* fetcher = CreateFetcher(GURL(url));
+ net::URLFetcher* fetcher = CreateFetcher(GURL(url)).release();
fetchers_[fetcher->GetOriginalURL()] = std::make_pair(token, fetcher);
fetcher->Start();
}
@@ -199,10 +199,10 @@ void GaiaCookieManagerService::ExternalCcResultFetcher::
GetCheckConnectionInfoCompleted(false);
}
-net::URLFetcher*
+scoped_ptr<net::URLFetcher>
GaiaCookieManagerService::ExternalCcResultFetcher::CreateFetcher(
const GURL& url) {
- net::URLFetcher* fetcher =
+ scoped_ptr<net::URLFetcher> fetcher =
net::URLFetcher::Create(0, url, net::URLFetcher::GET, this);
fetcher->SetRequestContext(helper_->request_context());
fetcher->SetLoadFlags(net::LOAD_DO_NOT_SEND_COOKIES |
@@ -457,8 +457,8 @@ void GaiaCookieManagerService::StartLogOutUrlFetch() {
VLOG(1) << "GaiaCookieManagerService::StartLogOutUrlFetch";
GURL logout_url(GaiaUrls::GetInstance()->service_logout_url().Resolve(
base::StringPrintf("?source=%s", source_.c_str())));
- logout_url_request_.reset(
- net::URLFetcher::Create(logout_url, net::URLFetcher::GET, this));
+ logout_url_request_ =
+ net::URLFetcher::Create(logout_url, net::URLFetcher::GET, this);
logout_url_request_->SetRequestContext(
signin_client_->GetURLRequestContext());
logout_url_request_->Start();
« no previous file with comments | « components/signin/core/browser/gaia_cookie_manager_service.h ('k') | components/suggestions/suggestions_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698