components/signin/core/browser/gaia_cookie_manager_service.h - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/gaia_cookie_manager_service.h

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unneeded Pass() calls Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/search_provider_logos/logo_tracker.cc ('k') | components/signin/core/browser/gaia_cookie_manager_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/signin/core/browser/gaia_cookie_manager_service.h

diff --git a/components/signin/core/browser/gaia_cookie_manager_service.h b/components/signin/core/browser/gaia_cookie_manager_service.h

index 941cb3529ec6cc57ce4175ddf2ad29f1492043a4..d5b6c51fcfd9e7bd0275b348500cbf99003b77ef 100644

--- a/components/signin/core/browser/gaia_cookie_manager_service.h

+++ b/components/signin/core/browser/gaia_cookie_manager_service.h

@@ -128,7 +128,7 @@ class GaiaCookieManagerService : public KeyedService,

const GoogleServiceAuthError& error) override;

// Creates and initializes a URL fetcher for doing a connection check.

- net::URLFetcher* CreateFetcher(const GURL& url);

+ scoped_ptr<net::URLFetcher> CreateFetcher(const GURL& url);

// Overridden from URLFetcherDelgate.

void OnURLFetchComplete(const net::URLFetcher* source) override;

« no previous file with comments | « components/search_provider_logos/logo_tracker.cc ('k') | components/signin/core/browser/gaia_cookie_manager_service.cc » ('j') | no next file with comments »