components/suggestions/suggestions_service.h - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/suggestions/suggestions_service.h

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unneeded Pass() calls Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/signin/core/browser/gaia_cookie_manager_service.cc ('k') | components/suggestions/suggestions_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/suggestions/suggestions_service.h

diff --git a/components/suggestions/suggestions_service.h b/components/suggestions/suggestions_service.h

index b0d0f4c54461f1dbdd0e47af80c3c1d0e1d28d00..34e03622c6c1dbca92d3acd9617f443aac9746b4 100644

--- a/components/suggestions/suggestions_service.h

+++ b/components/suggestions/suggestions_service.h

@@ -111,7 +111,7 @@ class SuggestionsService : public KeyedService, public net::URLFetcherDelegate {

FRIEND_TEST_ALL_PREFIXES(SuggestionsServiceTest, UpdateBlacklistDelay);

// Creates a request to the suggestions service, properly setting headers.

- net::URLFetcher* CreateSuggestionsRequest(const GURL& url);

+ scoped_ptr<net::URLFetcher> CreateSuggestionsRequest(const GURL& url);

// net::URLFetcherDelegate implementation.

// Called when fetch request completes. Parses the received suggestions data,

« no previous file with comments | « components/signin/core/browser/gaia_cookie_manager_service.cc ('k') | components/suggestions/suggestions_service.cc » ('j') | no next file with comments »