chrome/browser/spellchecker/spelling_service_client_unittest.cc - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/spellchecker/spelling_service_client_unittest.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix another failure missed by my regex Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/spellchecker/spelling_service_client.cc ('K') | « chrome/browser/spellchecker/spelling_service_client.cc ('k') | chrome/browser/supervised_user/child_accounts/family_info_fetcher.cc » ('j') | chrome/browser/ui/webui/devtools_ui.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/spellchecker/spelling_service_client_unittest.cc

diff --git a/chrome/browser/spellchecker/spelling_service_client_unittest.cc b/chrome/browser/spellchecker/spelling_service_client_unittest.cc

index 3f2516dd63b2f4b59aa97522e0e1350db4b2664c..09f5ccee7cfba657437d46a13566678cca6124c9 100644

--- a/chrome/browser/spellchecker/spelling_service_client_unittest.cc

+++ b/chrome/browser/spellchecker/spelling_service_client_unittest.cc

@@ -166,13 +166,13 @@ class TestingSpellingServiceClient : public SpellingServiceClient {

}

private:

- net::URLFetcher* CreateURLFetcher(const GURL& url) override {

+ scoped_ptr<net::URLFetcher> CreateURLFetcher(const GURL& url) override {

EXPECT_EQ("https://www.googleapis.com/rpc", url.spec());

fetcher_ = new TestSpellingURLFetcher(0, url, this,

request_type_, request_text_,

request_language_,

response_status_, response_data_);

- return fetcher_;

+ return scoped_ptr<net::URLFetcher>(fetcher_);

}

int request_type_;