Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

chrome/browser/safe_browsing/srt_fetcher_win.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/safe_browsing/srt_fetcher_win.h"
 
 #include "base/files/file_path.h"
 #include "base/metrics/field_trial.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/safe_browsing/srt_field_trial_win.h"
@@ skipping 58 matching lines @@
 // Class that will attempt to download the SRT, showing the SRT notification
 // bubble when the download operation is complete. Instances of SRTFetcher own
 // themselves, they will self-delete on completion of the network request when
 // OnURLFetchComplete is called.
 class SRTFetcher : public net::URLFetcherDelegate {
  public:
   SRTFetcher()
       : url_fetcher_(net::URLFetcher::Create(0,
                                              GURL(GetSRTDownloadURL()),
                                              net::URLFetcher::GET,
-                                             this)) {
+                                             this).Pass()) {

[Ryan Sleevi, 2015/04/30 18:23:44]

Is the .Pass() needed here for these emplacements? I didn't think so, but memory
fails me :)

[dtapuska, 2015/04/30 19:05:56]

Pass() is the safe bet.. I was concerned about compilers which I didn't have
available to me.. ie; MSVC

     url_fetcher_->SetLoadFlags(net::LOAD_DISABLE_CACHE);
     url_fetcher_->SetMaxRetriesOn5xx(3);
     url_fetcher_->SaveResponseToTemporaryFile(
         BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE));
     url_fetcher_->SetRequestContext(
         g_browser_process->system_request_context());
     url_fetcher_->Start();
   }
 
   // net::URLFetcherDelegate:
@@ skipping 39 matching lines @@
 }  // namespace
 
 namespace safe_browsing {
 
 void FetchSRTAndDisplayBubble() {
   // All the work happens in the self-deleting class above.
   new SRTFetcher();
 }
 
 }  // namespace safe_browsing