Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1117613003: [chrome/browser/net] favor DCHECK_CURRENTLY_ON for better logs (Closed)

Created:
5 years, 7 months ago by anujsharma
Modified:
5 years, 7 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, cbentzel+watch_chromium.org, eroman, mmenke, extensions-reviews_chromium.org, Mostyn Bramley-Moore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/net BUG=466848 Committed: https://crrev.com/2e02ce16df4540728922aedf4a8955c0dd346228 Cr-Commit-Position: refs/heads/master@{#327606}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -112 lines) Patch
M chrome/browser/net/chrome_extensions_network_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/chrome_http_user_agent_settings.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context_getter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/net/cookie_store_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/crl_set_fetcher.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/net/net_error_tab_helper.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/net/net_log_temp_file.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/net/net_pref_observer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/net/nss_context.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/net/nss_context_chromeos.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/net/nss_context_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/net/prediction_options.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/net/predictor.cc View 35 chunks +37 lines, -37 lines 0 comments Download
M chrome/browser/net/predictor_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/net/pref_proxy_config_tracker_impl.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/net/proxy_service_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/net/sdch_browsertest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/net/ssl_config_service_manager_pref.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/url_request_mock_util.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
anujsharma
PTAL
5 years, 7 months ago (2015-04-29 06:40:59 UTC) #2
Ryan Sleevi
lgtm
5 years, 7 months ago (2015-04-29 22:18:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1117613003/1
5 years, 7 months ago (2015-04-29 22:19:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 23:10:07 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 23:11:01 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2e02ce16df4540728922aedf4a8955c0dd346228
Cr-Commit-Position: refs/heads/master@{#327606}

Powered by Google App Engine
This is Rietveld 408576698