Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2293)

Unified Diff: chrome/browser/net/sdch_browsertest.cc

Issue 1117613003: [chrome/browser/net] favor DCHECK_CURRENTLY_ON for better logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/proxy_service_factory.cc ('k') | chrome/browser/net/ssl_config_service_manager_pref.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/sdch_browsertest.cc
diff --git a/chrome/browser/net/sdch_browsertest.cc b/chrome/browser/net/sdch_browsertest.cc
index a3748af4583121ccdfc4b1289806196436dd0373..591ad3a9ba73e9699c8db56269031b198b8b0f8a 100644
--- a/chrome/browser/net/sdch_browsertest.cc
+++ b/chrome/browser/net/sdch_browsertest.cc
@@ -534,7 +534,7 @@ class SdchBrowserTest : public InProcessBrowserTest,
private:
static void NukeSdchDictionariesOnIOThread(
net::URLRequestContextGetter* context_getter) {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
net::SdchManager* sdch_manager =
context_getter->GetURLRequestContext()->sdch_manager();
DCHECK(sdch_manager);
@@ -544,7 +544,7 @@ class SdchBrowserTest : public InProcessBrowserTest,
void GetNumberOfDictionaryFetchesOnIOThread(
net::URLRequestContextGetter* context_getter,
int* result) {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
net::SdchManager* manager(
context_getter->GetURLRequestContext()->sdch_manager());
@@ -591,7 +591,7 @@ class SdchBrowserTest : public InProcessBrowserTest,
void SubscribeToSdchNotifications(
net::URLRequestContextGetter* context_getter) {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
net::SdchManager* manager =
context_getter->GetURLRequestContext()->sdch_manager();
@@ -602,7 +602,7 @@ class SdchBrowserTest : public InProcessBrowserTest,
}
void UnsubscribeFromAllSdchNotifications() {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
for (auto it = fetch_counts_.begin(); it != fetch_counts_.end(); ++it)
it->first->RemoveObserver(this);
@@ -617,7 +617,7 @@ class SdchBrowserTest : public InProcessBrowserTest,
void OnGetDictionary(net::SdchManager* manager,
const GURL& request_url,
const GURL& dictionary_url) override {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
DLOG(ERROR) << "Retrieving count of notifications from manager " << manager;
DCHECK(fetch_counts_.end() != fetch_counts_.find(manager));
++fetch_counts_[manager];
« no previous file with comments | « chrome/browser/net/proxy_service_factory.cc ('k') | chrome/browser/net/ssl_config_service_manager_pref.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698