Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6974)

Unified Diff: chrome/browser/net/crl_set_fetcher.cc

Issue 1117613003: [chrome/browser/net] favor DCHECK_CURRENTLY_ON for better logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/cookie_store_util.cc ('k') | chrome/browser/net/net_error_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/crl_set_fetcher.cc
diff --git a/chrome/browser/net/crl_set_fetcher.cc b/chrome/browser/net/crl_set_fetcher.cc
index 09f9a9c15143aa9e941c1ff2891e130aad2b5d92..41189520b051e242493b6cd0ba4361a5d9d26030 100644
--- a/chrome/browser/net/crl_set_fetcher.cc
+++ b/chrome/browser/net/crl_set_fetcher.cc
@@ -36,7 +36,7 @@ base::FilePath CRLSetFetcher::GetCRLSetFilePath() const {
void CRLSetFetcher::StartInitialLoad(ComponentUpdateService* cus,
const base::FilePath& path) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
if (path.empty())
return;
SetCRLSetFilePath(path);
@@ -50,7 +50,7 @@ void CRLSetFetcher::StartInitialLoad(ComponentUpdateService* cus,
}
void CRLSetFetcher::DeleteFromDisk(const base::FilePath& path) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
if (path.empty())
return;
@@ -63,7 +63,7 @@ void CRLSetFetcher::DeleteFromDisk(const base::FilePath& path) {
}
void CRLSetFetcher::DoInitialLoadFromDisk() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
+ DCHECK_CURRENTLY_ON(BrowserThread::FILE);
LoadFromDisk(GetCRLSetFilePath(), &crl_set_);
@@ -87,7 +87,7 @@ void CRLSetFetcher::LoadFromDisk(base::FilePath path,
scoped_refptr<net::CRLSet>* out_crl_set) {
TRACE_EVENT0("CRLSetFetcher", "LoadFromDisk");
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
+ DCHECK_CURRENTLY_ON(BrowserThread::FILE);
std::string crl_set_bytes;
{
@@ -113,7 +113,7 @@ void CRLSetFetcher::LoadFromDisk(base::FilePath path,
void CRLSetFetcher::SetCRLSetIfNewer(
scoped_refptr<net::CRLSet> crl_set) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
scoped_refptr<net::CRLSet> old_crl_set(net::SSLConfigService::GetCRLSet());
if (old_crl_set.get() && old_crl_set->sequence() > crl_set->sequence()) {
@@ -137,7 +137,7 @@ static const uint8 kPublicKeySHA256[32] = {
};
void CRLSetFetcher::RegisterComponent(uint32 sequence_of_loaded_crl) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
update_client::CrxComponent component;
component.pk_hash.assign(kPublicKeySHA256,
@@ -158,7 +158,7 @@ void CRLSetFetcher::RegisterComponent(uint32 sequence_of_loaded_crl) {
}
void CRLSetFetcher::DoDeleteFromDisk() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
+ DCHECK_CURRENTLY_ON(BrowserThread::FILE);
DeleteFile(GetCRLSetFilePath(), false /* not recursive */);
}
« no previous file with comments | « chrome/browser/net/cookie_store_util.cc ('k') | chrome/browser/net/net_error_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698