Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1117423003: remove redundant/deprecated TwoPointRadial gradiet -- use TwoPointConical (Closed)

Created:
5 years, 7 months ago by reed1
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove redundant/deprecated TwoPointRadial gradiet -- use TwoPointConical This CL derived from https://codereview.chromium.org/1114243005/ BUG=skia: Committed: https://skia.googlesource.com/skia/+/71a6cbfc585959738dc0b375603696ca7f60605f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1132 lines) Patch
M bench/GradientBench.cpp View 4 chunks +0 lines, -19 lines 0 comments Download
M gm/blurrect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/blurroundrect.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M gm/gradients.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M gm/gradients_no_texture.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/shadertext.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
D gm/twopointradial.cpp View 1 chunk +0 lines, -112 lines 0 comments Download
M gyp/effects.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkShader.h View 3 chunks +1 line, -15 lines 0 comments Download
M include/effects/SkGradientShader.h View 1 chunk +0 lines, -33 lines 0 comments Download
M samplecode/Sample2PtRadial.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M samplecode/SampleGradients.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M samplecode/SampleShaderText.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M samplecode/SampleSlides.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/device/xps/SkXPSDevice.cpp View 3 chunks +1 line, -7 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 3 chunks +0 lines, -26 lines 0 comments Download
D src/effects/gradients/SkTwoPointRadialGradient.h View 1 chunk +0 lines, -64 lines 0 comments Download
D src/effects/gradients/SkTwoPointRadialGradient.cpp View 1 chunk +0 lines, -724 lines 0 comments Download
M src/gpu/GrProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
M src/pdf/SkPDFShader.cpp View 4 chunks +1 line, -65 lines 0 comments Download
M tests/GradientTest.cpp View 2 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
reed1
ptal
5 years, 7 months ago (2015-05-04 15:27:15 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1117423003/1
5 years, 7 months ago (2015-05-04 15:28:20 UTC) #4
bungeman-skia
I have no issues, lgtm
5 years, 7 months ago (2015-05-04 15:31:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1117423003/1
5 years, 7 months ago (2015-05-04 15:32:12 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-04 15:32:58 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/71a6cbfc585959738dc0b375603696ca7f60605f

Powered by Google App Engine
This is Rietveld 408576698