Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: chrome/browser/ui/webui/help/version_updater_basic.cc

Issue 1117263002: Switch on-demand update checks to the less-old GoogleUpdate3 API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: latest comments, better parent window handling, proper Google Update API Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/help/version_updater_basic.cc
diff --git a/chrome/browser/ui/webui/help/version_updater_basic.cc b/chrome/browser/ui/webui/help/version_updater_basic.cc
index ded19e0a55aeae8088f6456800e9360664060f22..5348e137cbaf2a8c113f50e5a80b97916ce45f85 100644
--- a/chrome/browser/ui/webui/help/version_updater_basic.cc
+++ b/chrome/browser/ui/webui/help/version_updater_basic.cc
@@ -20,6 +20,7 @@ void VersionUpdaterBasic::RelaunchBrowser() const {
chrome::AttemptRestart();
}
-VersionUpdater* VersionUpdater::Create(content::BrowserContext* /* context */) {
+VersionUpdater* VersionUpdater::Create(
+ content::WebContents* /* web_contents */) {
Peter Kasting 2015/05/12 22:04:34 Nit: Do we actually need to comment out the param
grt (UTC plus 2) 2015/05/13 13:04:05 The comment in common.gypi that disables the warni
Peter Kasting 2015/05/13 22:40:55 I'm actually the one on the team working on enabli
return new VersionUpdaterBasic;
}

Powered by Google App Engine
This is Rietveld 408576698