Switch on-demand update checks to the less-old GoogleUpdate3 API.

chrome/browser/ui/webui/help/version_updater_basic.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/help/version_updater_basic.h"
 
 #include "base/strings/string16.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
 #include "chrome/browser/upgrade_detector.h"
 
 void VersionUpdaterBasic::CheckForUpdate(
     const StatusCallback& status_callback) {
   if (UpgradeDetector::GetInstance()->notify_upgrade())
     status_callback.Run(NEARLY_UPDATED, 0, base::string16());
   else
     status_callback.Run(DISABLED, 0, base::string16());
 }
 
 void VersionUpdaterBasic::RelaunchBrowser() const {
   chrome::AttemptRestart();
 }
 
-VersionUpdater* VersionUpdater::Create(content::BrowserContext* /* context */) {
+VersionUpdater* VersionUpdater::Create(
+    content::WebContents* /* web_contents */) {

[Peter Kasting, 2015/05/12 22:04:34]

Nit: Do we actually need to comment out the param name?  I thought we built with
that warning disabled...

[grt (UTC plus 2), 2015/05/13 13:04:05]

The comment in common.gypi that disables the warning has "These warnings are
level 4. They will be slowly removed as code is fixed." above it, so I think
there's an intent to enable it some day.

[Peter Kasting, 2015/05/13 22:40:55]

I'm actually the one on the team working on enabling those warnings, and I have
no intent to ever enable this :)

   return new VersionUpdaterBasic;
 }