chrome/browser/ui/webui/help/version_updater_mac.mm - Issue 1117263002: Switch on-demand update checks to the less-old GoogleUpdate3 API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/help/version_updater_mac.mm

Issue 1117263002: Switch on-demand update checks to the less-old GoogleUpdate3 API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: latest comments, better parent window handling, proper Google Update API Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/help/version_updater_basic.cc ('K') | « chrome/browser/ui/webui/help/version_updater_chromeos.cc ('k') | chrome/browser/ui/webui/help/version_updater_win.cc » ('j') | chrome/browser/ui/webui/help/version_updater_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/help/version_updater_mac.mm

diff --git a/chrome/browser/ui/webui/help/version_updater_mac.mm b/chrome/browser/ui/webui/help/version_updater_mac.mm

index d185a873470ec5869772468ec73efc330a87e811..ea76b22e919ce6a33f9265ced05d2a85cb761fe6 100644

--- a/chrome/browser/ui/webui/help/version_updater_mac.mm

+++ b/chrome/browser/ui/webui/help/version_updater_mac.mm

@@ -53,7 +53,8 @@

@end // @implementation KeystoneObserver

-VersionUpdater* VersionUpdater::Create(content::BrowserContext* /* context */) {

+VersionUpdater* VersionUpdater::Create(

+ content::WebContents* /* web_contents */) {

Peter Kasting 2015/05/12 22:04:34 Nit: Same comment

return new VersionUpdaterMac;

}