Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1117123005: [CSS Grid Layout] grid-template-areas should accept none value (Closed)

Created:
5 years, 7 months ago by Manuel Rego
Modified:
5 years, 7 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, jfernandez, Manuel Rego, rwlbuis, svillar
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[CSS Grid Layout] grid-template-areas should accept none value Default value for grid-template-areas property is "none": http://dev.w3.org/csswg/css-grid/#propdef-grid-template-areas Currently if you set the property to "none" from JavaScript, the value doesn't get reseted and it keeps the old value. This patch adds support to parse it successfully and updates the test adding the new case. TEST=fast/css-grid-layout/grid-template-areas-get-set.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194926

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html View 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-template-areas-get-set-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Manuel Rego
5 years, 7 months ago (2015-05-05 09:30:14 UTC) #2
svillar
Informal lgtm
5 years, 7 months ago (2015-05-05 09:33:30 UTC) #4
dsinclair
lgtm
5 years, 7 months ago (2015-05-05 14:28:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1117123005/1
5 years, 7 months ago (2015-05-05 14:28:27 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 16:23:00 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194926

Powered by Google App Engine
This is Rietveld 408576698