Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Side by Side Diff: LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html

Issue 1117123005: [CSS Grid Layout] grid-template-areas should accept none value (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | LayoutTests/fast/css-grid-layout/grid-template-areas-get-set-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"> 1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
2 <html> 2 <html>
3 <head> 3 <head>
4 <link href="resources/grid.css" rel="stylesheet"> 4 <link href="resources/grid.css" rel="stylesheet">
5 <style> 5 <style>
6 #gridWithSingleStringTemplate { 6 #gridWithSingleStringTemplate {
7 grid-template-areas: "area"; 7 grid-template-areas: "area";
8 } 8 }
9 9
10 #gridWithTwoColumnsTemplate { 10 #gridWithTwoColumnsTemplate {
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 84
85 var gridWithVerticalRectangle = document.getElementById("gridWithVerticalRec tangle"); 85 var gridWithVerticalRectangle = document.getElementById("gridWithVerticalRec tangle");
86 shouldBeEqualToString("window.getComputedStyle(gridWithVerticalRectangle).ge tPropertyValue('grid-template-areas')", '"a a" "a a" "a a"'); 86 shouldBeEqualToString("window.getComputedStyle(gridWithVerticalRectangle).ge tPropertyValue('grid-template-areas')", '"a a" "a a" "a a"');
87 87
88 debug("Test grid-template-areas: initial"); 88 debug("Test grid-template-areas: initial");
89 var element = document.createElement("div"); 89 var element = document.createElement("div");
90 document.body.appendChild(element); 90 document.body.appendChild(element);
91 element.style.gridTemplateAreas = "'foobar'"; 91 element.style.gridTemplateAreas = "'foobar'";
92 shouldBeEqualToString("window.getComputedStyle(element).getPropertyValue('gr id-template-areas')", '"foobar"') 92 shouldBeEqualToString("window.getComputedStyle(element).getPropertyValue('gr id-template-areas')", '"foobar"')
93 element.style.gridTemplateAreas = "initial"; 93 element.style.gridTemplateAreas = "initial";
94 shouldBeEqualToString("window.getComputedStyle(element).getPropertyValue('gr id-template-areas')", 'none');
95 element.style.gridTemplateAreas = "'foobar'";
96 shouldBeEqualToString("window.getComputedStyle(element).getPropertyValue('gr id-template-areas')", '"foobar"')
97 element.style.gridTemplateAreas = "none";
98 shouldBeEqualToString("window.getComputedStyle(element).getPropertyValue('gr id-template-areas')", 'none');
94 document.body.removeChild(element); 99 document.body.removeChild(element);
95 100
96 debug("Test grid-template-areas: inherit"); 101 debug("Test grid-template-areas: inherit");
97 var parentElement = document.createElement("div"); 102 var parentElement = document.createElement("div");
98 document.body.appendChild(parentElement); 103 document.body.appendChild(parentElement);
99 parentElement.style.gridTemplateAreas = "'foo bar'"; 104 parentElement.style.gridTemplateAreas = "'foo bar'";
100 shouldBeEqualToString("window.getComputedStyle(parentElement).getPropertyVal ue('grid-template-areas')", '"foo bar"') 105 shouldBeEqualToString("window.getComputedStyle(parentElement).getPropertyVal ue('grid-template-areas')", '"foo bar"')
101 106
102 var element = document.createElement("div"); 107 var element = document.createElement("div");
103 parentElement.appendChild(element); 108 parentElement.appendChild(element);
(...skipping 26 matching lines...) Expand all
130 shouldBeEqualToString("window.getComputedStyle(element).getPropertyValue('gr id-template-areas')", "none") 135 shouldBeEqualToString("window.getComputedStyle(element).getPropertyValue('gr id-template-areas')", "none")
131 136
132 debug(""); 137 debug("");
133 debug("FIXME: We currently don't validate that the named grid areas are &lt; indent&gt;."); 138 debug("FIXME: We currently don't validate that the named grid areas are &lt; indent&gt;.");
134 // <ident> only allows a leading '-'. 139 // <ident> only allows a leading '-'.
135 element.style.gridTemplateAreas = '"nav-up"'; 140 element.style.gridTemplateAreas = '"nav-up"';
136 shouldBeEqualToString("window.getComputedStyle(element).getPropertyValue('gr id-template-areas')", "none") 141 shouldBeEqualToString("window.getComputedStyle(element).getPropertyValue('gr id-template-areas')", "none")
137 </script> 142 </script>
138 </body> 143 </body>
139 </html> 144 </html>
OLDNEW
« no previous file with comments | « no previous file | LayoutTests/fast/css-grid-layout/grid-template-areas-get-set-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698