Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1314)

Unified Diff: content/renderer/render_view_impl.cc

Issue 1117023002: Keep event page alive when there's some Pepper plugin on it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index eb9971320db4aaff0a97e71a2efcc757be981ee0..5a5d18b3bb11a2ccc42f1d70af1a2ccf29fc779a 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -204,6 +204,8 @@
#include "content/renderer/npapi/webplugin_delegate_proxy.h"
#include "content/renderer/pepper/pepper_plugin_instance_impl.h"
#include "content/renderer/pepper/pepper_plugin_registry.h"
+#include "content/renderer/pepper/plugin_module.h"
bartfab (slow) 2015/05/18 09:57:41 Nit: Where are you using these new includes?
emaxx 2015/05/18 15:06:30 Done.
+#include "content/renderer/pepper/renderer_ppapi_host_impl.h"
#endif
#if defined(ENABLE_WEBRTC)
@@ -1179,6 +1181,7 @@ blink::WebView* RenderViewImpl::webview() const {
void RenderViewImpl::PepperInstanceCreated(
PepperPluginInstanceImpl* instance) {
active_pepper_instances_.insert(instance);
+ Send(new ViewHostMsg_PepperInstanceCreated(GetRoutingID()));
nasko 2015/05/11 16:24:09 This can be sent through the instance RenderFrame.
emaxx 2015/05/18 15:06:30 I'm not sure what did you mean. Now I've changed t
nasko 2015/05/19 14:11:45 This seems slightly incorrect. The PepperPluginIns
emaxx 2015/05/19 17:33:40 Done.
}
void RenderViewImpl::PepperInstanceDeleted(
@@ -1189,6 +1192,7 @@ void RenderViewImpl::PepperInstanceDeleted(
pepper_last_mouse_event_target_ = NULL;
if (focused_pepper_plugin_ == instance)
PepperFocusChanged(instance, false);
+ Send(new ViewHostMsg_PepperInstanceDeleted(GetRoutingID()));
nasko 2015/05/11 16:24:09 Same as above.
emaxx 2015/05/18 15:06:29 Done.
}
void RenderViewImpl::PepperFocusChanged(PepperPluginInstanceImpl* instance,

Powered by Google App Engine
This is Rietveld 408576698