Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Unified Diff: content/public/browser/web_contents_observer.h

Issue 1117023002: Keep event page alive when there's some Pepper plugin on it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/web_contents_observer.h
diff --git a/content/public/browser/web_contents_observer.h b/content/public/browser/web_contents_observer.h
index b040d64223fe81a143daaedff660bad609e10dd2..7b3a51974a48f776a68b6d253e8539a673d41104 100644
--- a/content/public/browser/web_contents_observer.h
+++ b/content/public/browser/web_contents_observer.h
@@ -278,6 +278,11 @@ class CONTENT_EXPORT WebContentsObserver : public IPC::Listener,
virtual void AppCacheAccessed(const GURL& manifest_url,
bool blocked_by_policy) {}
+ // These methods are invoked when a Pepper plugin instance is
+ // attached/detached in the page DOM.
nasko 2015/05/11 16:24:09 The comment uses "attached/detached", but the name
emaxx 2015/05/18 15:06:29 The notifications are only about Pepper instances
nasko 2015/05/19 14:11:45 If this notification is about plugin being added t
emaxx 2015/05/19 17:33:40 As far as I understand, no real loading is perform
+ virtual void PepperInstanceCreated() {}
+ virtual void PepperInstanceDeleted() {}
+
// Notification that a plugin has crashed.
// |plugin_pid| is the process ID identifying the plugin process. Note that
// this ID is supplied by the renderer process, so should not be trusted.

Powered by Google App Engine
This is Rietveld 408576698