Keep event page alive when there's some Pepper plugin on it.

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/auto_reset.h"
@@ skipping 186 matching lines @@
 #elif defined(USE_X11)
 #include "ui/native_theme/native_theme.h"
 #elif defined(OS_MACOSX)
 #include "skia/ext/skia_utils_mac.h"
 #endif
 
 #if defined(ENABLE_PLUGINS)
 #include "content/renderer/npapi/webplugin_delegate_proxy.h"
 #include "content/renderer/pepper/pepper_plugin_instance_impl.h"
 #include "content/renderer/pepper/pepper_plugin_registry.h"
+#include "content/renderer/pepper/plugin_module.h"

[bartfab (slow), 2015/05/18 09:57:41]

Nit: Where are you using these new includes?

[emaxx, 2015/05/18 15:06:30]

Done.

+#include "content/renderer/pepper/renderer_ppapi_host_impl.h"
 #endif
 
 #if defined(ENABLE_WEBRTC)
 #include "content/renderer/media/rtc_peer_connection_handler.h"
 #include "content/renderer/media/webrtc/peer_connection_dependency_factory.h"
 #endif
 
 using blink::WebAXObject;
 using blink::WebApplicationCacheHost;
 using blink::WebApplicationCacheHostClient;
@@ skipping 955 matching lines @@
 }
 
 blink::WebView* RenderViewImpl::webview() const {
   return static_cast<blink::WebView*>(webwidget());
 }
 
 #if defined(ENABLE_PLUGINS)
 void RenderViewImpl::PepperInstanceCreated(
     PepperPluginInstanceImpl* instance) {
   active_pepper_instances_.insert(instance);
+  Send(new ViewHostMsg_PepperInstanceCreated(GetRoutingID()));

[nasko, 2015/05/11 16:24:09]

This can be sent through the instance RenderFrame.

[emaxx, 2015/05/18 15:06:30]

I'm not sure what did you mean. Now I've changed the code here to send the
message through GetMainRenderFrame() - is that what you wanted?

[nasko, 2015/05/19 14:11:45]

This seems slightly incorrect. The PepperPluginInstanceImpl is associated with a
RenderFrame instance, which is accessible through render_frame(). See
https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/p....
This should be the frame used to send the message, not the main frame.

[emaxx, 2015/05/19 17:33:40]

Done.

 }
 
 void RenderViewImpl::PepperInstanceDeleted(
     PepperPluginInstanceImpl* instance) {
   active_pepper_instances_.erase(instance);
 
   if (pepper_last_mouse_event_target_ == instance)
     pepper_last_mouse_event_target_ = NULL;
   if (focused_pepper_plugin_ == instance)
     PepperFocusChanged(instance, false);
+  Send(new ViewHostMsg_PepperInstanceDeleted(GetRoutingID()));

[nasko, 2015/05/11 16:24:09]

Same as above.

[emaxx, 2015/05/18 15:06:29]

Done.

 }
 
 void RenderViewImpl::PepperFocusChanged(PepperPluginInstanceImpl* instance,
                                         bool focused) {
   if (focused)
     focused_pepper_plugin_ = instance;
   else if (focused_pepper_plugin_ == instance)
     focused_pepper_plugin_ = NULL;
 
   UpdateTextInputType();
@@ skipping 2567 matching lines @@
     std::vector<gfx::Size> sizes;
     ConvertToFaviconSizes(icon_urls[i].sizes(), &sizes);
     if (!url.isEmpty())
       urls.push_back(
           FaviconURL(url, ToFaviconType(icon_urls[i].iconType()), sizes));
   }
   SendUpdateFaviconURL(urls);
 }
 
 }  // namespace content