Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 111633003: Removes some dead database code (Closed)

Created:
7 years ago by sky
Modified:
7 years ago
Reviewers:
brettw
CC:
chromium-reviews, browser-components-watch_chromium.org
Visibility:
Public.

Description

Removes some dead database code This code isn't needed anymore. BUG=none TEST=none R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242040

Patch Set 1 #

Patch Set 2 : leave idle comment #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -458 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/history/history_backend.h View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/history/history_backend.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M chrome/browser/history/history_backend_unittest.cc View 5 chunks +5 lines, -93 lines 0 comments Download
M chrome/browser/history/history_service.h View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/history/history_service.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M chrome/browser/history/history_tab_helper.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/history/history_types.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/page_usage_data.h View 3 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/history/visitsegment_database.h View 4 chunks +0 lines, -42 lines 0 comments Download
M chrome/browser/history/visitsegment_database.cc View 9 chunks +67 lines, -218 lines 1 comment Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
https://codereview.chromium.org/111633003/diff/20001/chrome/browser/history/visitsegment_database.cc File chrome/browser/history/visitsegment_database.cc (left): https://codereview.chromium.org/111633003/diff/20001/chrome/browser/history/visitsegment_database.cc#oldcode36 chrome/browser/history/visitsegment_database.cc:36: // segment_duration This was only ever used if you ...
7 years ago (2013-12-18 00:13:58 UTC) #1
brettw
lgtm
7 years ago (2013-12-19 21:11:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/111633003/20001
7 years ago (2013-12-19 21:46:06 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-20 08:03:02 UTC) #4
Message was sent while issue was closed.
Change committed as 242040

Powered by Google App Engine
This is Rietveld 408576698