chrome/browser/history/history_tab_helper.cc - Issue 111633003: Removes some dead database code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/history_tab_helper.cc

Issue 111633003: Removes some dead database code (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: leave idle comment Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/history/history_tab_helper.cc

diff --git a/chrome/browser/history/history_tab_helper.cc b/chrome/browser/history/history_tab_helper.cc

index 22567445123d5b32c5e3d4fcedc4abd3a38660a9..03ccc8157f2f73e4ad75c88d34b47967bfb6f21f 100644

--- a/chrome/browser/history/history_tab_helper.cc

+++ b/chrome/browser/history/history_tab_helper.cc

@@ -154,9 +154,6 @@ HistoryService* HistoryTabHelper::GetHistoryService() {

}

void HistoryTabHelper::WebContentsDestroyed(WebContents* tab) {

- // TODO(sky): nuke this since no one is using visit_duration (and this is all

- // wrong).

// We update the history for this URL.

// The content returned from web_contents() has been destroyed by now.

// We need to use tab value directly.