Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1277)

Unified Diff: chrome/browser/history/visitsegment_database.h

Issue 111633003: Removes some dead database code (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: leave idle comment Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/visitsegment_database.h
diff --git a/chrome/browser/history/visitsegment_database.h b/chrome/browser/history/visitsegment_database.h
index 49f9f632818207e899b890b043047693ca01ef25..b2242882eef0493d37f26ee33be0c51ad455ad27 100644
--- a/chrome/browser/history/visitsegment_database.h
+++ b/chrome/browser/history/visitsegment_database.h
@@ -12,7 +12,6 @@ class PageUsageData;
namespace sql {
class Connection;
-class Statement;
}
namespace history {
@@ -28,10 +27,6 @@ class VisitSegmentDatabase {
// source url spec less some information such as query strings.
static std::string ComputeSegmentName(const GURL& url);
- // The segment tables use the time as a key for visit count and duration. This
- // returns the appropriate time.
- static base::Time SegmentTime(base::Time time);
-
// Returns the ID of the segment with the corresponding name, or 0 if there
// is no segment with that name.
SegmentID GetSegmentNamed(const std::string& segment_name);
@@ -73,28 +68,6 @@ class VisitSegmentDatabase {
// This will also delete any associated segment usage data.
bool DeleteSegmentForURL(URLID url_id);
- // Creates a new SegmentDurationID for the SegmentID and Time pair. The
- // duration is set to |delta|.
- SegmentDurationID CreateSegmentDuration(SegmentID segment_id,
- base::Time time,
- base::TimeDelta delta);
-
- // Sets the duration of the |duration_id| to |time_delta|.
- bool SetSegmentDuration(SegmentDurationID duration_id,
- base::TimeDelta time_delta);
-
- // Gets the SegmentDurationID of the |segment_id| and |time| pair. Returns
- // true on success and sets |duration_id| and |time_delta| appropriately.
- bool GetSegmentDuration(SegmentID segment_id,
- base::Time time,
- SegmentDurationID* duration_id,
- base::TimeDelta* time_delta);
-
- // Queries segments by duration.
- void QuerySegmentDuration(base::Time from_time,
- int max_result_count,
- std::vector<PageUsageData*>* result);
-
protected:
// Returns the database for the functions in this interface.
virtual sql::Connection& GetDB() = 0;
@@ -111,21 +84,6 @@ class VisitSegmentDatabase {
bool MigratePresentationIndex();
private:
- enum QueryType {
- QUERY_VISIT_COUNT,
- QUERY_DURATION,
- };
-
- // Used by both QuerySegment fucntions.
- void QuerySegmentsCommon(sql::Statement* statement,
- base::Time from_time,
- int max_result_count,
- QueryType query_type,
- std::vector<PageUsageData*>* result);
-
- // Was the |segment_duration| table created?
- const bool has_duration_table_;
-
DISALLOW_COPY_AND_ASSIGN(VisitSegmentDatabase);
};

Powered by Google App Engine
This is Rietveld 408576698