Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 1115853004: Reland "Remove the weak list of array buffers" (Closed)

Created:
5 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 7 months ago
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "Remove the weak list of array buffers" Original issue's description: > Remove the weak list of array buffers > > Instead, collect live array buffers during marking and free pointers we > no longer found. > > BUG=v8:3996 > R=hpayer@chromium.org > LOG=n BUG=v8:3996 TBR=hpayer@chromium.org LOG=n Committed: https://crrev.com/ac1c88a9b27973e6976a9f72ac84a0ebf940293e Cr-Commit-Position: refs/heads/master@{#28156}

Patch Set 1 #

Patch Set 2 : ignore empty array buffers #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -275 lines) Patch
M src/api.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/heap-snapshot-generator.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/heap.h View 6 chunks +9 lines, -13 lines 0 comments Download
M src/heap/heap.cc View 1 3 chunks +37 lines, -36 lines 4 comments Download
M src/heap/mark-compact.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/objects-visiting.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/heap/objects-visiting.cc View 5 chunks +5 lines, -40 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 2 chunks +5 lines, -9 lines 0 comments Download
M src/objects.h View 2 chunks +1 line, -5 lines 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/runtime/runtime-typedarray.cc View 4 chunks +3 lines, -31 lines 0 comments Download
M src/snapshot/serialize.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D test/cctest/test-weaktypedarrays.cc View 1 chunk +0 lines, -124 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
jochen (gone - plz use gerrit)
fyi I forgot about array buffers with a NULL backing store (and 0 length...)
5 years, 7 months ago (2015-04-30 09:50:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1115853004/20001
5 years, 7 months ago (2015-04-30 09:50:54 UTC) #3
Hannes Payer (out of office)
https://codereview.chromium.org/1115853004/diff/20001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1115853004/diff/20001/src/heap/heap.cc#newcode1726 src/heap/heap.cc:1726: if (!data) return; How can this one be null? ...
5 years, 7 months ago (2015-04-30 10:35:30 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-04-30 10:57:50 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ac1c88a9b27973e6976a9f72ac84a0ebf940293e Cr-Commit-Position: refs/heads/master@{#28156}
5 years, 7 months ago (2015-04-30 10:58:04 UTC) #6
jochen (gone - plz use gerrit)
5 years, 7 months ago (2015-04-30 12:01:08 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/1115853004/diff/20001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/1115853004/diff/20001/src/heap/heap.cc#newcod...
src/heap/heap.cc:1726: if (!data) return;
On 2015/04/30 10:35:29, Hannes Payer wrote:
> How can this one be null?

malloc(0) returns 0 as well

https://codereview.chromium.org/1115853004/diff/20001/src/heap/heap.cc#newcod...
src/heap/heap.cc:1734: if (!data) return;
On 2015/04/30 10:35:29, Hannes Payer wrote:
> This one can only be null in the neuter case right?

also for on-heap typed arrays

Powered by Google App Engine
This is Rietveld 408576698