src/heap-snapshot-generator.cc - Issue 1115853004: Reland "Remove the weak list of array buffers"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap-snapshot-generator.cc

Issue 1115853004: Reland "Remove the weak list of array buffers" (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: ignore empty array buffers Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap-snapshot-generator.cc

diff --git a/src/heap-snapshot-generator.cc b/src/heap-snapshot-generator.cc

index 654cda4644f9c00f423693ca6d8e91a8b5da982c..34db11ba5d8f197b01924adea218d5e82c163463 100644

--- a/src/heap-snapshot-generator.cc

+++ b/src/heap-snapshot-generator.cc

@@ -1566,8 +1566,6 @@ class JSArrayBufferDataEntryAllocator : public HeapEntriesAllocator {

void V8HeapExplorer::ExtractJSArrayBufferReferences(

int entry, JSArrayBuffer* buffer) {

- SetWeakReference(buffer, entry, "weak_next", buffer->weak_next(),

- JSArrayBuffer::kWeakNextOffset);

// Setup a reference to a native memory backing_store object.

if (!buffer->backing_store())

return;

« no previous file with comments | « src/api.cc ('k') | src/heap/heap.h » ('j') | src/heap/heap.cc » ('J')