src/snapshot/serialize.cc - Issue 1115853004: Reland "Remove the weak list of array buffers"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/snapshot/serialize.cc

Issue 1115853004: Reland "Remove the weak list of array buffers" (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: ignore empty array buffers Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/snapshot/serialize.cc

diff --git a/src/snapshot/serialize.cc b/src/snapshot/serialize.cc

index 26f8da3af8a036719e38dbea237f1296da2b9476..dbe92a6accb129520b22838e09ea8a7f3ee485a1 100644

--- a/src/snapshot/serialize.cc

+++ b/src/snapshot/serialize.cc

@@ -563,10 +563,6 @@ void Deserializer::Deserialize(Isolate* isolate) {

isolate_->heap()->set_native_contexts_list(

isolate_->heap()->undefined_value());

- isolate_->heap()->set_array_buffers_list(

- isolate_->heap()->undefined_value());

- isolate_->heap()->set_last_array_buffer_in_list(

- isolate_->heap()->undefined_value());

// The allocation site list is build during root iteration, but if no sites

// were encountered then it needs to be initialized to undefined.