Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1115463002: Fix mojo and mandoline android build breaks. (Closed)

Created:
5 years, 7 months ago by msw
Modified:
5 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix mojo and mandoline android build breaks. Exclude the mandoline target on android for now (no main). Rename the test targets to avoid naming conflicts... (android GN targets doesn't seem to respect output_name) Update the namespace for mojo::util::FilePathToFileURL call. See initial breakage at http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Android/builds/384 The relevant CLs are: https://codereview.chromium.org/1109993002 https://codereview.chromium.org/1091513005 BUG=466129 TEST=Building mojo and mandoline for android passes. R=sky@chromium.org,ben@chromium.org Committed: https://crrev.com/887c30157baaa9242a798ba8a5a4884d9564b11f Cr-Commit-Position: refs/heads/master@{#327361}

Patch Set 1 #

Patch Set 2 : Exclude mandoline target on android for now; fix GN targets. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M mandoline/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/BUILD.gn View 1 2 chunks +4 lines, -6 lines 0 comments Download
M mojo/runner/shell_test_base_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/BUILD.gn View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
msw
Hey Scott and Ben, please take a look; thanks! (I'd like to get android to ...
5 years, 7 months ago (2015-04-28 19:41:36 UTC) #2
sky
LGTM
5 years, 7 months ago (2015-04-28 19:45:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1115463002/20001
5 years, 7 months ago (2015-04-28 19:51:46 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-04-28 20:53:29 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 20:54:16 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/887c30157baaa9242a798ba8a5a4884d9564b11f
Cr-Commit-Position: refs/heads/master@{#327361}

Powered by Google App Engine
This is Rietveld 408576698