Adds support for mojo apps to live in their own directory

Adds support for mojo apps to live in their own directory

I added the new gn target mandoline_native_application that
creates the directory and changed html_viewer to use it.

URLResource tries to find a directory, if it exists the directory is
preferred over the raw name. If the directory doesn't exist, than use
foo.mojo.

R=ben@chromium.org

Committed: https://crrev.com/d7a009a4ffa9b580e7f84f3cadf8146753dc3ad2
Cr-Commit-Position: refs/heads/master@{#327278}

[sky, 2015-04-27 21:04:39]

I'll wait until you land your patch before trying to land this.

[Ben Goodger (Google), 2015-04-27 21:30:03]

https://codereview.chromium.org/1109993002/diff/20001/mandoline/mandoline_app...
File mandoline/mandoline_application.gni (right):

https://codereview.chromium.org/1109993002/diff/20001/mandoline/mandoline_app...
mandoline/mandoline_application.gni:12: template("mandoline_native_application")
{
Can we put this in mojo and call it mojo_application_package?

[sky, 2015-04-27 21:35:33]

https://codereview.chromium.org/1109993002/diff/20001/mandoline/mandoline_app...
File mandoline/mandoline_application.gni (right):

https://codereview.chromium.org/1109993002/diff/20001/mandoline/mandoline_app...
mandoline/mandoline_application.gni:12: template("mandoline_native_application")
{
On 2015/04/27 21:30:03, Ben Goodger (Google) wrote:
> Can we put this in mojo and call it mojo_application_package?

Done.

[Ben Goodger (Google), 2015-04-27 21:52:49]

https://codereview.chromium.org/1109993002/diff/40001/mojo/mojo_application_p...
File mojo/mojo_application_package.gni (right):

https://codereview.chromium.org/1109993002/diff/40001/mojo/mojo_application_p...
mojo/mojo_application_package.gni:30: mojo_deps += [ ":copy_mandoline_resources"
]
copy_mojo_application_resources??

[Ben Goodger (Google), 2015-04-27 21:57:59]

lgtm

[sky, 2015-04-28 13:11:15]

The CQ bit was checked by sky@chromium.org

[sky, 2015-04-28 13:11:16]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org
Link to the patchset: https://codereview.chromium.org/1109993002/#ps100001
(title: "merge to trunk and move filename_util to own dir")

[commit-bot: I haz the power, 2015-04-28 13:11:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1109993002/100001

[commit-bot: I haz the power, 2015-04-28 13:15:19]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-04-28 13:46:22]

Patchset 6 (id:??) landed as
https://crrev.com/d7a009a4ffa9b580e7f84f3cadf8146753dc3ad2
Cr-Commit-Position: refs/heads/master@{#327278}

[qsr, 2015-04-30 09:20:55]

Any reason this is design in the shell itself instead of using a content
handler. You could have the following structure:

dir.mojo/manifest.mojo
dir.mojo/dir.mojo
dir.mojo/resource

At its bare minimum, manifest.mojo will just have a single line:
#!mojo:dir_content_handler.mojo

And content_handler.mojo will be a content handler that expect the response it
receive to have a file:/// url, and will then get access to the directory to run
the application.

[sky, 2015-04-30 17:49:41]

This would mean you have to connect to mojo:foo/manifest.mojo, which
isn't particularly satisfying. I suppose I could look for a
manifest.mojo and for you, but then I may as well do the logic I'm
doing now. I'm not sure a file url would work, it would have to be
relative. Additionally having the content handler have to run the
application itself isn't particularly satisfying either.

I agree that it would be possible to implement this as a content
handler, it just doesn't feel particularly satisfying. Adding first
class support for apps to have resources feels more natural.

  -Scott

On Thu, Apr 30, 2015 at 2:20 AM,  <qsr@chromium.org> wrote:
> Any reason this is design in the shell itself instead of using a content
> handler. You could have the following structure:
>
> dir.mojo/manifest.mojo
> dir.mojo/dir.mojo
> dir.mojo/resource
>
> At its bare minimum, manifest.mojo will just have a single line:
> #!mojo:dir_content_handler.mojo
>
> And content_handler.mojo will be a content handler that expect the response
> it
> receive to have a file:/// url, and will then get access to the directory to
> run
> the application.
>
> https://codereview.chromium.org/1109993002/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.