Have document.evaluate() report TypeError over incorrect resolvers.

Have document.evaluate() report TypeError over incorrect resolvers.

Switch from reporting TypeMismatchError to TypeError to align with
other implementations (and WebIDL) when faced with resolver arguments
that do not have a function type.

To help format the error message about an incorrectly typed argument,
introduced ExceptionMessages::incorrectArgumentType().

R=
BUG=270033
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163533

[sof, 2013-12-10 11:12:32]

At your leisure, please take a look.

[Mike West, 2013-12-10 11:20:40]

LGTM with one note.

https://codereview.chromium.org/111533002/diff/1/Source/bindings/v8/Exception...
File Source/bindings/v8/ExceptionMessages.h (right):

https://codereview.chromium.org/111533002/diff/1/Source/bindings/v8/Exception...
Source/bindings/v8/ExceptionMessages.h:47: static String
incorrectPropertyType(const String& property, const String& detail = String());
Hrm. I'm not convinced that we want to let people avoid adding a detail string
to either of these items. It seems friendlier to the web developer if the
callsite has to say something about what it was expecting.

[sof, 2013-12-10 11:42:09]

On 2013/12/10 11:20:40, Mike West wrote:
> LGTM with one note.
> 
>
https://codereview.chromium.org/111533002/diff/1/Source/bindings/v8/Exception...
> File Source/bindings/v8/ExceptionMessages.h (right):
> 
>
https://codereview.chromium.org/111533002/diff/1/Source/bindings/v8/Exception...
> Source/bindings/v8/ExceptionMessages.h:47: static String
> incorrectPropertyType(const String& property, const String& detail =
String());
> Hrm. I'm not convinced that we want to let people avoid adding a detail string
> to either of these items. It seems friendlier to the web developer if the
> callsite has to say something about what it was expecting.

ok, dropped/reverted the optional argument support.

[commit-bot: I haz the power, 2013-12-10 11:42:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sigbjornf@opera.com/111533002/20001

[commit-bot: I haz the power, 2013-12-10 12:49:58]

Change committed as 163533