Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: Source/bindings/v8/ExceptionMessages.h

Issue 111533002: Have document.evaluate() report TypeError over incorrect resolvers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: The detail argument is no longer optional. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/xpath/invalid-resolver-expected.txt ('k') | Source/bindings/v8/ExceptionMessages.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/ExceptionMessages.h
diff --git a/Source/bindings/v8/ExceptionMessages.h b/Source/bindings/v8/ExceptionMessages.h
index eb7421eec672b41be4fbc8f2dc669b4a1e2b79ea..92f8a9f58792290b53e2ef71ff1f64d2a13e0e8c 100644
--- a/Source/bindings/v8/ExceptionMessages.h
+++ b/Source/bindings/v8/ExceptionMessages.h
@@ -42,6 +42,8 @@ public:
static String failedToGet(const String& property, const String& type, const String& detail);
static String failedToSet(const String& property, const String& type, const String& detail);
static String failedToDelete(const String& property, const String& type, const String& detail);
+
+ static String incorrectArgumentType(int argumentIndex, const String& detail);
static String incorrectPropertyType(const String& property, const String& detail);
// If > 0, the argument index that failed type check (1-indexed.)
« no previous file with comments | « LayoutTests/fast/xpath/invalid-resolver-expected.txt ('k') | Source/bindings/v8/ExceptionMessages.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698