Source/bindings/v8/ExceptionMessages.h - Issue 111533002: Have document.evaluate() report TypeError over incorrect resolvers.

Side by Side Diff: Source/bindings/v8/ExceptionMessages.h

Issue 111533002: Have document.evaluate() report TypeError over incorrect resolvers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2013 Google Inc. All rights reserved.	2 * Copyright (C) 2013 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 24 matching lines...) Expand all Loading...
35	35

36 namespace WebCore {	36 namespace WebCore {

37	37

38 class ExceptionMessages {	38 class ExceptionMessages {

39 public:	39 public:

40 static String failedToConstruct(const String& type, const String& detail = S tring());	40 static String failedToConstruct(const String& type, const String& detail = S tring());

41 static String failedToExecute(const String& method, const String& type, cons t String& detail = String());	41 static String failedToExecute(const String& method, const String& type, cons t String& detail = String());

42 static String failedToGet(const String& property, const String& type, const String& detail);	42 static String failedToGet(const String& property, const String& type, const String& detail);

43 static String failedToSet(const String& property, const String& type, const String& detail);	43 static String failedToSet(const String& property, const String& type, const String& detail);

44 static String failedToDelete(const String& property, const String& type, con st String& detail);	44 static String failedToDelete(const String& property, const String& type, con st String& detail);

45 static String incorrectPropertyType(const String& property, const String& de tail);	45

	46 static String incorrectArgumentType(int argumentIndex, const String& detail = String());

	47 static String incorrectPropertyType(const String& property, const String& de tail = String());
	Mike West 2013/12/10 11:20:42 Hrm. I'm not convinced that we want to let people Hrm. I'm not convinced that we want to let people avoid adding a detail string to either of these items. It seems friendlier to the web developer if the callsite has to say something about what it was expecting.
46	48

47 // If > 0, the argument index that failed type check (1-indexed.)	49 // If > 0, the argument index that failed type check (1-indexed.)

48 // If == 0, a (non-argument) value (e.g., a setter) failed the same check.	50 // If == 0, a (non-argument) value (e.g., a setter) failed the same check.

49 static String notAnArrayTypeArgumentOrValue(int argumentIndex);	51 static String notAnArrayTypeArgumentOrValue(int argumentIndex);

50 static String notASequenceTypeProperty(const String& propertyName);	52 static String notASequenceTypeProperty(const String& propertyName);

51 static String notAFiniteNumber(double value);	53 static String notAFiniteNumber(double value);

52	54

53 static String notEnoughArguments(unsigned expected, unsigned providedleastNu mMandatoryParams);	55 static String notEnoughArguments(unsigned expected, unsigned providedleastNu mMandatoryParams);

54	56

55 private:	57 private:

56 static String ordinalNumber(int number);	58 static String ordinalNumber(int number);

57 };	59 };

58	60

59 } // namespace WebCore	61 } // namespace WebCore

60	62

61 #endif // ExceptionMessages_h	63 #endif // ExceptionMessages_h

OLD	NEW

« no previous file with comments | « LayoutTests/fast/xpath/invalid-resolver-expected.txt ('k') | Source/bindings/v8/ExceptionMessages.cpp » ('j') | no next file with comments »