Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1114653002: Suppress all CHECK failures on extension renderer JS exceptions. (Closed)

Created:
5 years, 7 months ago by not at google - send to devlin
Modified:
5 years, 7 months ago
Reviewers:
adamk
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Suppress all CHECK failures on extension renderer JS exceptions. These will be added back once the cause of the crashes is fixed. BUG=471599 R=adamk@chromium.org Committed: https://crrev.com/ec0e3aa3ac1cacc1fdcc74d2bec7a3f8dea6ac72 Cr-Commit-Position: refs/heads/master@{#327369}

Patch Set 1 #

Patch Set 2 : duh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M chrome/common/extensions/chrome_extensions_client.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M extensions/renderer/module_system.cc View 1 chunk +4 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
not at google - send to devlin
5 years, 7 months ago (2015-04-28 18:50:10 UTC) #1
adamk
lgtm
5 years, 7 months ago (2015-04-28 18:53:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1114653002/1
5 years, 7 months ago (2015-04-28 19:00:37 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/47442)
5 years, 7 months ago (2015-04-28 19:21:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1114653002/20001
5 years, 7 months ago (2015-04-28 20:41:31 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-04-28 21:50:40 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 21:52:33 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ec0e3aa3ac1cacc1fdcc74d2bec7a3f8dea6ac72
Cr-Commit-Position: refs/heads/master@{#327369}

Powered by Google App Engine
This is Rietveld 408576698