Suppress all CHECK failures on extension renderer JS exceptions.

extensions/renderer/module_system.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/module_system.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/stl_util.h"
@@ skipping 13 matching lines @@
 
 namespace extensions {
 
 namespace {
 
 const char* kModuleSystem = "module_system";
 const char* kModuleName = "module_name";
 const char* kModuleField = "module_field";
 const char* kModulesField = "modules";
 
-// Logs a fatal error for the calling context, with some added metadata about
-// the context:
+// Logs an error for the calling context in preparation for potentially
+// crashing the renderer, with some added metadata about the context:
 //  - Its type (blessed, unblessed, etc).
 //  - Whether it's valid.
 //  - The extension ID, if one exists.
-//
-// This will only actual be fatal in in dev/canary, since in too many cases
-// we're at the mercy of the extension or web page's environment. They can mess
-// up our JS in unexpected ways. Hopefully dev/canary channel will pick up such
-// problems, but given the wider variety on stable/beta it's impossible to know.
+// Crashing won't happen in stable/beta releases, but is encouraged to happen
+// in the less stable released to catch errors early.
 void Fatal(ScriptContext* context, const std::string& message) {
   // Prepend some context metadata.
   std::string full_message = "(";
   if (!context->is_valid())
     full_message += "Invalid ";
   full_message += context->GetContextTypeDescription();
   full_message += " context";
   if (context->extension()) {
     full_message += " for ";
     full_message += context->extension()->id();
@@ skipping 633 matching lines @@
 
 void ModuleSystem::ClobberExistingNativeHandler(const std::string& name) {
   NativeHandlerMap::iterator existing_handler = native_handler_map_.find(name);
   if (existing_handler != native_handler_map_.end()) {
     clobbered_native_handlers_.push_back(existing_handler->second);
     native_handler_map_.erase(existing_handler);
   }
 }
 
 }  // namespace extensions