Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2869)

Unified Diff: extensions/renderer/module_system.cc

Issue 1114653002: Suppress all CHECK failures on extension renderer JS exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: duh Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/chrome_extensions_client.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/module_system.cc
diff --git a/extensions/renderer/module_system.cc b/extensions/renderer/module_system.cc
index 6a120749f4107499b322fc42f998c9f83528a703..0b75e96edd460a2dd4dd55641127e9c64fdc17db 100644
--- a/extensions/renderer/module_system.cc
+++ b/extensions/renderer/module_system.cc
@@ -31,16 +31,13 @@ const char* kModuleName = "module_name";
const char* kModuleField = "module_field";
const char* kModulesField = "modules";
-// Logs a fatal error for the calling context, with some added metadata about
-// the context:
+// Logs an error for the calling context in preparation for potentially
+// crashing the renderer, with some added metadata about the context:
// - Its type (blessed, unblessed, etc).
// - Whether it's valid.
// - The extension ID, if one exists.
-//
-// This will only actual be fatal in in dev/canary, since in too many cases
-// we're at the mercy of the extension or web page's environment. They can mess
-// up our JS in unexpected ways. Hopefully dev/canary channel will pick up such
-// problems, but given the wider variety on stable/beta it's impossible to know.
+// Crashing won't happen in stable/beta releases, but is encouraged to happen
+// in the less stable released to catch errors early.
void Fatal(ScriptContext* context, const std::string& message) {
// Prepend some context metadata.
std::string full_message = "(";
« no previous file with comments | « chrome/common/extensions/chrome_extensions_client.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698