Issue 11143006: Set kChangesNewSpacePromotion for HStringAdd

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11143006: Set kChangesNewSpacePromotion for HStringAdd (Closed)

Created:
8 years, 2 months ago by Jay Conrod

Modified:
8 years, 1 month ago

Reviewers:
ulan, Michael Starzinger, danno

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Set kChangesNewSpacePromotion for HStringAdd TEST=none BUG=none Committed: https://code.google.com/p/v8/source/detail?r=12822

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	AUTHORS	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/hydrogen-instructions.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 1 (0 generated)

Michael Starzinger

8 years, 1 month ago (2012-10-25 15:17:54 UTC) #1

LGTM. I tried to come up with a reproduction for that, but I just cannot get
this to reproduce. So I'll land it without a regression test.