Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/hydrogen-instructions.h

Issue 11143006: Set kChangesNewSpacePromotion for HStringAdd (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4698 matching lines...) Expand 10 before | Expand all | Expand 10 after
4709 }; 4709 };
4710 4710
4711 4711
4712 class HStringAdd: public HBinaryOperation { 4712 class HStringAdd: public HBinaryOperation {
4713 public: 4713 public:
4714 HStringAdd(HValue* context, HValue* left, HValue* right) 4714 HStringAdd(HValue* context, HValue* left, HValue* right)
4715 : HBinaryOperation(context, left, right) { 4715 : HBinaryOperation(context, left, right) {
4716 set_representation(Representation::Tagged()); 4716 set_representation(Representation::Tagged());
4717 SetFlag(kUseGVN); 4717 SetFlag(kUseGVN);
4718 SetGVNFlag(kDependsOnMaps); 4718 SetGVNFlag(kDependsOnMaps);
4719 SetGVNFlag(kChangesNewSpacePromotion);
4719 } 4720 }
4720 4721
4721 virtual Representation RequiredInputRepresentation(int index) { 4722 virtual Representation RequiredInputRepresentation(int index) {
4722 return Representation::Tagged(); 4723 return Representation::Tagged();
4723 } 4724 }
4724 4725
4725 virtual HType CalculateInferredType() { 4726 virtual HType CalculateInferredType() {
4726 return HType::String(); 4727 return HType::String();
4727 } 4728 }
4728 4729
(...skipping 560 matching lines...) Expand 10 before | Expand all | Expand 10 after
5289 DECLARE_CONCRETE_INSTRUCTION(LoadFieldByIndex); 5290 DECLARE_CONCRETE_INSTRUCTION(LoadFieldByIndex);
5290 }; 5291 };
5291 5292
5292 5293
5293 #undef DECLARE_INSTRUCTION 5294 #undef DECLARE_INSTRUCTION
5294 #undef DECLARE_CONCRETE_INSTRUCTION 5295 #undef DECLARE_CONCRETE_INSTRUCTION
5295 5296
5296 } } // namespace v8::internal 5297 } } // namespace v8::internal
5297 5298
5298 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 5299 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698