Issue 1114223002: Rename AssemblerX86 to AssemblerX8632 so it works with SZTargets.def.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1114223002: Rename AssemblerX86 to AssemblerX8632 so it works with SZTargets.def. (Closed)

Created:
5 years, 7 months ago by jvoung (off chromium)

Modified:
5 years, 7 months ago

Reviewers:
Karl, Jim Stichnoth, Mircea Trofin

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Rename AssemblerX86 to AssemblerX8632 so it works with SZTargets.def. This is to conditionally (ifdef) include only the enabled target assemblers. Also rename the assembler's "x86" namespace to "X8632" for similar reasons. The namespace was created to hide generic sounding classes like "Address" which are used all over the assembler. Plop the somewhat empty AssemblerARM32 in an ARM32 namespace for consistency. BUG=none R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=90ccc3fac766a127a7ae6833a47f92c385cd07c0

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+665 lines, -643 lines)			Patch
M	src/IceInstX8632.h	View	12 chunks	+15 lines, -15 lines	0 comments	Download
M	src/IceInstX8632.cpp	View	79 chunks	+289 lines, -272 lines	0 comments	Download
M	src/IceTargetLowering.cpp	View	1 chunk	+4 lines, -9 lines	0 comments	Download
M	src/IceTargetLoweringX8632.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/IceTargetLoweringX8632.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/assembler_arm32.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/assembler_ia32.h	View	9 chunks	+48 lines, -45 lines	0 comments	Download
M	src/assembler_ia32.cpp	View	180 chunks	+304 lines, -299 lines	0 comments	Download

Total messages: 4 (1 generated)

jvoung (off chromium)

5 years, 7 months ago (2015-04-30 21:15:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
90ccc3fac766a127a7ae6833a47f92c385cd07c0 (presubmit successful).